Issue 320923004: Revert of Revert of Sheriffing: Disable failing tests PrintCommands and TaskManagerNewPrintPreview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 320923004: Revert of Revert of Sheriffing: Disable failing tests PrintCommands and TaskManagerNewPrintPreview (Closed)

Created:
6 years, 6 months ago by alph

Modified:
6 years, 6 months ago

Reviewers:
Lei Zhang, Miguel Garcia, jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Revert of Sheriffing: Disable failing tests PrintCommands and TaskManagerNewPrintPreview on Linux LSAN (https://codereview.chromium.org/323893003/) Reason for revert: It's not guilty! Original issue's description: > Revert of Sheriffing: Disable failing tests PrintCommands and TaskManagerNewPrintPreview on Linux LSAN (https://codereview.chromium.org/319783003/) > > Reason for revert: > Broke compile Android Bot (http://build.chromium.org/p/chromium.linux/builders/Android%20GN) > > Original issue's description: > > Sheriffing: Disable failing tests PrintCommands and TaskManagerNewPrintPreview on Linux LSAN > > > > TBR=thestig@chromium.org,jam@chromium.org > > NOTRY=true > > BUG=382523 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275820 > > TBR=jam@chromium.org,thestig@chromium.org,alph@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=382523 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275823 TBR=jam@chromium.org,thestig@chromium.org,miguelg@chromium.org NOTREECHECKS=true NOTRY=true BUG=382523 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275828

Created: 6 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

alph

Created Revert of Revert of Sheriffing: Disable failing tests PrintCommands and TaskManagerNewPrintPreview on Linux LSAN

6 years, 6 months ago (2014-06-09 17:11:34 UTC) #1

Lei Zhang

6 years, 6 months ago (2014-06-09 19:00:30 UTC) #2

Message was sent while issue was closed.

lgtm

Sigh, I tested locally with ASAN on. Will try again and see if I can repro this.