Safeguard for webMediaPlayer() access

Safeguard for webMediaPlayer() access in createImageBitmap() incase webMediaPlayer() and m_readystate of media element are out of sync

BUG=350571
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175943

[Srirama, 2014-06-09 19:00:41]

This is a preventive check to avoid a possible crash which can occur similar to
381556 and 381570. This will be removed once we find the actual reason why
webMediaPlayer() is null when the m_readystate is >= HAVE_METADATA.

[acolwell GONE FROM CHROMIUM, 2014-06-09 23:09:36]

lgtm % nit

https://codereview.chromium.org/320843002/diff/1/Source/modules/imagebitmap/I...
File Source/modules/imagebitmap/ImageBitmapFactories.cpp (right):

https://codereview.chromium.org/320843002/diff/1/Source/modules/imagebitmap/I...
Source/modules/imagebitmap/ImageBitmapFactories.cpp:135: if (video->readyState()
<= HTMLMediaElement::HAVE_METADATA) {
nit: I think you should probably just make the null check here and add a FIXME
comment saying that the null check should be removed once we fix Bug 382721.

[Srirama, 2014-06-10 05:50:25]

abarth@: Owners review please

https://codereview.chromium.org/320843002/diff/1/Source/modules/imagebitmap/I...
File Source/modules/imagebitmap/ImageBitmapFactories.cpp (right):

https://codereview.chromium.org/320843002/diff/1/Source/modules/imagebitmap/I...
Source/modules/imagebitmap/ImageBitmapFactories.cpp:135: if (video->readyState()
<= HTMLMediaElement::HAVE_METADATA) {
On 2014/06/09 23:09:36, acolwell wrote:
> nit: I think you should probably just make the null check here and add a FIXME
> comment saying that the null check should be removed once we fix Bug 382721.

Done.

[abarth-chromium, 2014-06-11 03:34:52]

LGTM, but please add some more information to the description.  The first
comment gives some good context that would be valuable in the description (which
becomes part of the git history).

[Srirama, 2014-06-11 03:45:06]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2014-06-11 03:45:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/srirama.m@samsung.com/320843002/20001

[commit-bot: I haz the power, 2014-06-11 04:51:09]

Change committed as 175943