Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 320843002: Safeguard for webMediaPlayer() access (Closed)

Created:
6 years, 6 months ago by Srirama
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Safeguard for webMediaPlayer() access in createImageBitmap() incase webMediaPlayer() and m_readystate of media element are out of sync BUG=350571 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175943

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Srirama
This is a preventive check to avoid a possible crash which can occur similar to ...
6 years, 6 months ago (2014-06-09 19:00:41 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm % nit https://codereview.chromium.org/320843002/diff/1/Source/modules/imagebitmap/ImageBitmapFactories.cpp File Source/modules/imagebitmap/ImageBitmapFactories.cpp (right): https://codereview.chromium.org/320843002/diff/1/Source/modules/imagebitmap/ImageBitmapFactories.cpp#newcode135 Source/modules/imagebitmap/ImageBitmapFactories.cpp:135: if (video->readyState() <= HTMLMediaElement::HAVE_METADATA) { nit: ...
6 years, 6 months ago (2014-06-09 23:09:36 UTC) #2
Srirama
abarth@: Owners review please https://codereview.chromium.org/320843002/diff/1/Source/modules/imagebitmap/ImageBitmapFactories.cpp File Source/modules/imagebitmap/ImageBitmapFactories.cpp (right): https://codereview.chromium.org/320843002/diff/1/Source/modules/imagebitmap/ImageBitmapFactories.cpp#newcode135 Source/modules/imagebitmap/ImageBitmapFactories.cpp:135: if (video->readyState() <= HTMLMediaElement::HAVE_METADATA) { ...
6 years, 6 months ago (2014-06-10 05:50:25 UTC) #3
abarth-chromium
LGTM, but please add some more information to the description. The first comment gives some ...
6 years, 6 months ago (2014-06-11 03:34:52 UTC) #4
Srirama
The CQ bit was checked by srirama.m@samsung.com
6 years, 6 months ago (2014-06-11 03:45:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srirama.m@samsung.com/320843002/20001
6 years, 6 months ago (2014-06-11 03:45:59 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 04:51:09 UTC) #7
Message was sent while issue was closed.
Change committed as 175943

Powered by Google App Engine
This is Rietveld 408576698