content/child/indexed_db/indexed_db_dispatcher.h - Issue 320833002: [IndexedDB] Use consistent enums on both sides of IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/indexed_db/indexed_db_dispatcher.h

Issue 320833002: [IndexedDB] Use consistent enums on both sides of IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/indexed_db/indexed_db_dispatcher_host.cc ('K') | « content/browser/indexed_db/indexed_db_transaction_unittest.cc ('k') | content/child/indexed_db/indexed_db_dispatcher.cc » ('j') | content/common/indexed_db/indexed_db_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/indexed_db/indexed_db_dispatcher.h

diff --git a/content/child/indexed_db/indexed_db_dispatcher.h b/content/child/indexed_db/indexed_db_dispatcher.h

index c4159bec5d565c6fbf3afd9a380bece201c81cb8..7350afef666521e245d289fc85e59d49ca6425ff 100644

--- a/content/child/indexed_db/indexed_db_dispatcher.h

+++ b/content/child/indexed_db/indexed_db_dispatcher.h

@@ -17,9 +17,8 @@

#include "ipc/ipc_sync_message_filter.h"

#include "third_party/WebKit/public/platform/WebBlobInfo.h"

#include "third_party/WebKit/public/platform/WebIDBCallbacks.h"

-#include "third_party/WebKit/public/platform/WebIDBCursor.h"

-#include "third_party/WebKit/public/platform/WebIDBDatabase.h"

#include "third_party/WebKit/public/platform/WebIDBDatabaseCallbacks.h"

+#include "third_party/WebKit/public/platform/WebIDBTypes.h"

struct IndexedDBDatabaseMetadata;

struct IndexedDBMsg_CallbacksSuccessCursorContinue_Params;

@@ -117,7 +116,7 @@ class CONTENT_EXPORT IndexedDBDispatcher : public WorkerTaskRunner::Observer {

int64 transaction_id,

blink::WebIDBDatabaseCallbacks* database_callbacks_ptr,

blink::WebVector<long long> object_store_ids,

- blink::WebIDBDatabase::TransactionMode mode);

+ blink::WebIDBTransactionMode mode);

void RequestIDBDatabaseGet(int32 ipc_database_id,

int64 transaction_id,

@@ -134,7 +133,7 @@ class CONTENT_EXPORT IndexedDBDispatcher : public WorkerTaskRunner::Observer {

const blink::WebData& value,

const blink::WebVector<blink::WebBlobInfo>& web_blob_info,

const IndexedDBKey& key,

- blink::WebIDBDatabase::PutMode put_mode,

+ blink::WebIDBPutMode put_mode,

blink::WebIDBCallbacks* callbacks,

const blink::WebVector<long long>& index_ids,

const blink::WebVector<blink::WebVector<blink::WebIDBKey> >& index_keys);

@@ -144,9 +143,9 @@ class CONTENT_EXPORT IndexedDBDispatcher : public WorkerTaskRunner::Observer {

int64 object_store_id,

int64 index_id,

const IndexedDBKeyRange& key_range,

- blink::WebIDBCursor::Direction direction,

+ blink::WebIDBCursorDirection direction,

bool key_only,

- blink::WebIDBDatabase::TaskType task_type,

+ blink::WebIDBTaskType task_type,

blink::WebIDBCallbacks* callbacks);

void RequestIDBDatabaseCount(int32 ipc_database_id,