content/browser/indexed_db/indexed_db_database.h - Issue 320833002: [IndexedDB] Use consistent enums on both sides of IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_database.h

Issue 320833002: [IndexedDB] Use consistent enums on both sides of IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/indexed_db/indexed_db_cursor.h ('K') | « content/browser/indexed_db/indexed_db_cursor.cc ('k') | content/browser/indexed_db/indexed_db_database.cc » ('j') | content/browser/indexed_db/indexed_db_transaction.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_database.h

diff --git a/content/browser/indexed_db/indexed_db_database.h b/content/browser/indexed_db/indexed_db_database.h

index 63a438a4bb6b95d13f4b9727b5a36da664053cb6..52ef9ebc597450d3d9a2ff3dac32ff4433f87081 100644

--- a/content/browser/indexed_db/indexed_db_database.h

+++ b/content/browser/indexed_db/indexed_db_database.h

@@ -37,11 +37,6 @@ struct IndexedDBValue;

class CONTENT_EXPORT IndexedDBDatabase

: NON_EXPORTED_BASE(public base::RefCounted<IndexedDBDatabase>) {

public:

- enum TaskType {

- NORMAL_TASK = 0,

- PREEMPTIVE_TASK

- };

enum PutMode {

jsbell 2014/06/09 16:38:27 Remove this enum too?

Pritam Nikam 2014/06/11 14:05:16 Done.

ADD_OR_UPDATE,

ADD_ONLY,

@@ -146,9 +141,9 @@ class CONTENT_EXPORT IndexedDBDatabase

int64 object_store_id,

int64 index_id,

scoped_ptr<IndexedDBKeyRange> key_range,

- indexed_db::CursorDirection,

+ blink::Direction,

bool key_only,

- TaskType task_type,

+ blink::TaskType task_type,

scoped_refptr<IndexedDBCallbacks> callbacks);

void Count(int64 transaction_id,

int64 object_store_id,