Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 320773002: Oilpan: Remove manual ref/deref of Nodes. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Visibility:
Public.

Description

Oilpan: Remove manual ref/deref of Nodes in XMLDocumentParser. Objects in XMLDocumentParser::m_currentNodeStack are correctly traces in Oilpan. We don't need ref/deref. Also, this CL replace one instance of Vector<Element*> with HeapVector<Member<Elemenet>>. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M Source/core/xml/parser/XMLDocumentParser.cpp View 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
Please review this.
6 years, 6 months ago (2014-06-09 02:00:39 UTC) #1
tkent
Actually, I don't understand why ref/deref are necessary for non-Oilpan. Anyway, enable_oilpan=1 should be safe.
6 years, 6 months ago (2014-06-09 02:01:34 UTC) #2
haraken
LGTM.
6 years, 6 months ago (2014-06-09 02:20:59 UTC) #3
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-09 02:32:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/320773002/1
6 years, 6 months ago (2014-06-09 02:32:20 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 02:40:24 UTC) #6
Message was sent while issue was closed.
Change committed as 175763

Powered by Google App Engine
This is Rietveld 408576698