Support javascript gtests in an extension background page.

chrome/test/base/extension_load_waiter.h

Index: chrome/test/base/extension_load_waiter.h
diff --git a/chrome/test/base/extension_load_waiter.h b/chrome/test/base/extension_load_waiter.h
new file mode 100644
index 0000000000000000000000000000000000000000..c9dfe2e6fae4eec891663670ff212cabfd4bb2a5
--- /dev/null
+++ b/chrome/test/base/extension_load_waiter.h
@@ -0,0 +1,47 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_TEST_BASE_EXTENSION_LOAD_WAITER_H_
+#define CHROME_TEST_BASE_EXTENSION_LOAD_WAITER_H_
+
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+#include "content/public/test/test_utils.h"
+
+namespace content {
+class BrowserContext;
+}  // namespace content
+
+// A class used to load and wait for the ChromeVox component extension.

[dmazzoni, 2014/06/10 16:06:16]

Update this comment, this waits for any extension to load.

[Peter Lundblad, 2014/06/11 16:45:06]

Remove chromevox here.

[Peter Lundblad, 2014/06/11 16:45:06]

Remove chromevox here.

[Peter Lundblad, 2014/06/11 16:45:07]

Remove chromevox here.

[David Tseng, 2014/06/11 17:52:55]

Already done.

+class ExtensionLoadWaiter : public content::NotificationObserver {
+ public:
+  ExtensionLoadWaiter();
+  virtual ~ExtensionLoadWaiter();
+
+  // Waits for extension with |extension_id| to load.

[Peter Lundblad, 2014/06/11 16:45:06]

                      ^
nit: Do you need a particle here?

[Peter Lundblad, 2014/06/11 16:45:07]

                      ^
nit: Do you need a particle here?

[Peter Lundblad, 2014/06/11 16:45:07]

                      ^
nit: Do you need a particle here?

[David Tseng, 2014/06/11 17:52:55]

Particle? Don't follow....it looks fine I think.

+  void WaitFor(const char* extension_id);

[Peter Lundblad, 2014/06/11 16:45:06]

Note in the docs that the extension id should be a static char array pointer.

[Peter Lundblad, 2014/06/11 16:45:06]

Note in the docs that the extension id should be a static char array pointer.

[Peter Lundblad, 2014/06/11 16:45:06]

Note in the docs that the extension id should be a static char array pointer.

[David Tseng, 2014/06/11 17:52:54]

You mean a pointer to a static char array? Ok sure.

+
+  // content::NotificationObserver overrides.
+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) OVERRIDE;
+
+  // Get the browser context associated with the loaded extension.

[Peter Lundblad, 2014/06/11 16:45:06]

Note that this can only be called after waiting for an extension.

[Peter Lundblad, 2014/06/11 16:45:06]

Note that this can only be called after waiting for an extension.

[Peter Lundblad, 2014/06/11 16:45:07]

Note that this can only be called after waiting for an extension.

[David Tseng, 2014/06/11 17:52:54]

You actually can call it; it will just be NULL. Clarified the doc.

+  content::BrowserContext* browser_context() { return browser_context_; }
+
+  // Get the id of the loaded extension.

[Peter Lundblad, 2014/06/11 16:45:06]

Either make this class a one-shot only or change documentation to  'last loaded
extension'.

[Peter Lundblad, 2014/06/11 16:45:06]

Either make this class a one-shot only or change documentation to  'last loaded
extension'.

[Peter Lundblad, 2014/06/11 16:45:07]

Either make this class a one-shot only or change documentation to  'last loaded
extension'.

[David Tseng, 2014/06/11 17:52:54]

Made one shot.

+  const char* extension_id() { return extension_id_; }
+
+ private:
+  void Reset();
+
+  content::NotificationRegistrar registrar_;
+  scoped_refptr<content::MessageLoopRunner> load_looper_;
+  const char* extension_id_;
+  content::BrowserContext* browser_context_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionLoadWaiter);
+};
+
+#endif  // CHROME_TEST_BASE_EXTENSION_LOAD_WAITER_H_