Support javascript gtests in an extension background page.

chrome/test/base/extension_load_waiter.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/test/base/extension_load_waiter.h"
+
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/common/extensions/extension_constants.h"
+#include "content/public/browser/browser_context.h"
+#include "content/public/browser/notification_service.h"
+#include "extensions/browser/extension_host.h"
+
+ExtensionLoadWaiter::ExtensionLoadWaiter()
+    : load_looper_(NULL), extension_id_(""), browser_context_(NULL) {

[Peter Lundblad, 2014/06/11 16:45:05]

No need to initialize scoped_refptr with NULL, set extension_id_ to NULL instead
of empty string?

[Peter Lundblad, 2014/06/11 16:45:05]

No need to initialize scoped_refptr with NULL, set extension_id_ to NULL instead
of empty string?

[Peter Lundblad, 2014/06/11 16:45:06]

No need to initialize scoped_refptr with NULL, set extension_id_ to NULL instead
of empty string?

[David Tseng, 2014/06/11 17:52:54]

Done.

+}
+
+ExtensionLoadWaiter::~ExtensionLoadWaiter() {
+}
+
+void ExtensionLoadWaiter::WaitFor(const char* extension_id) {
+  Reset();

[Peter Lundblad, 2014/06/11 16:45:05]

Suggestion: make this so that you can only wait once to make the state
management of this class less error-prone (say you wait for a second extension
and then something else uses the browser context believeing it is still for the
first extension).

[Peter Lundblad, 2014/06/11 16:45:06]

Suggestion: make this so that you can only wait once to make the state
management of this class less error-prone (say you wait for a second extension
and then something else uses the browser context believeing it is still for the
first extension).

[Peter Lundblad, 2014/06/11 16:45:06]

Suggestion: make this so that you can only wait once to make the state
management of this class less error-prone (say you wait for a second extension
and then something else uses the browser context believeing it is still for the
first extension).

[David Tseng, 2014/06/11 17:52:54]

Done.

+  extension_id_ = extension_id;
+  load_looper_ = new content::MessageLoopRunner();
+  registrar_.Add(this,
+                 chrome::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,
+                 content::NotificationService::AllSources());
+  load_looper_->Run();
+}
+
+void ExtensionLoadWaiter::Observe(int type,
+                                  const content::NotificationSource& source,
+                                  const content::NotificationDetails& details) {
+  switch (type) {
+    case chrome::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING: {
+      extensions::ExtensionHost* host =
+          content::Details<extensions::ExtensionHost>(details).ptr();
+      if (host->extension_id() == extension_id_) {
+        browser_context_ = host->browser_context();
+        registrar_.Remove(this,
+                          chrome::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,
+                          content::NotificationService::AllSources());
+        load_looper_->Quit();
+      }
+      break;
+    }
+  }
+}
+void ExtensionLoadWaiter::Reset() {

[dmazzoni, 2014/06/10 16:06:16]

Nit: blank line before

[David Tseng, 2014/06/10 20:14:25]

Done.

[Peter Lundblad, 2014/06/11 16:45:05]

nit: add blank line.

[Peter Lundblad, 2014/06/11 16:45:06]

nit: add blank line.

[Peter Lundblad, 2014/06/11 16:45:06]

nit: add blank line.

[David Tseng, 2014/06/11 17:52:54]

Already done.

+  extension_id_ = "";
+  load_looper_ = NULL;
+  browser_context_ = NULL;
+}