Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Issue 320713004: Update panel layout immediately after the user has finished resizing a panel. (Closed)

Created:
6 years, 6 months ago by pkotwicz
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tdanderson+views_chromium.org, jennb, tfarina, Dmitry Titov, dcheng, ben+views_chromium.org
Visibility:
Public.

Description

Update panel layout immediately after the user has finished resizing a panel. Update panel layout immediately after the user has finished resizing a panel. Unfortunately, it is not possible to detect when a resize performed by the window manager has ended. This CL does the resizing of panels entirely in Chrome. This is slow and ugly but it is what we used to do in the GTK port. (panel_drag_gtk.cc) BUG=371616 TEST=Manual, see bug R=erg, jianli TBR=sadrul (For changes in ui/base/x/x11_util.* which have been taken verbatim from https://codereview.chromium.org/264713007/) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276719

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -155 lines) Patch
M chrome/browser/ui/panels/panel_browsertest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_constants.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/panels/panel_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_manager.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel_resize_browsertest.cc View 1 26 chunks +36 lines, -53 lines 0 comments Download
M chrome/browser/ui/panels/panel_resize_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_resize_controller.cc View 1 2 5 chunks +38 lines, -37 lines 0 comments Download
M chrome/browser/ui/views/panels/panel_view.cc View 3 chunks +19 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/panels/x11_panel_resizer.h View 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/panels/x11_panel_resizer.cc View 1 chunk +127 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/x/x11_util.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 3 chunks +8 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 4 chunks +15 lines, -5 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 1 2 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
pkotwicz
Elliot, can you please take a look? Technically, we could call XQueryPointer() periodically to figure ...
6 years, 6 months ago (2014-06-08 01:40:09 UTC) #1
pkotwicz
Elliot, can you please take a look? Technically, we could call XQueryPointer() periodically to figure ...
6 years, 6 months ago (2014-06-08 02:11:20 UTC) #2
jianli
Please make sure you also test this on Windows. Thanks. On Sat, Jun 7, 2014 ...
6 years, 6 months ago (2014-06-09 17:32:39 UTC) #3
Elliot Glaysher
lgtm
6 years, 6 months ago (2014-06-10 18:00:04 UTC) #4
pkotwicz
jianli@ can you please take a look at the panel related changes? I have not ...
6 years, 6 months ago (2014-06-10 18:07:09 UTC) #5
pkotwicz
jianli@ can you please take a look at the panel related changes? I have not ...
6 years, 6 months ago (2014-06-10 18:07:31 UTC) #6
jianli
On 2014/06/10 18:07:31, pkotwicz wrote: > jianli@ can you please take a look at the ...
6 years, 6 months ago (2014-06-11 00:11:02 UTC) #7
pkotwicz
jianli@, what do you think of the CL though? X11PanelResizer makes use of PanelResizeController (indirectly ...
6 years, 6 months ago (2014-06-11 03:12:58 UTC) #8
jianli
lgtm
6 years, 6 months ago (2014-06-11 17:13:05 UTC) #9
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-11 19:42:47 UTC) #10
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-11 19:42:52 UTC) #11
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-11 19:45:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/320713004/180001
6 years, 6 months ago (2014-06-11 19:49:29 UTC) #13
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-11 20:55:36 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 20:56:28 UTC) #15
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-11 21:41:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/320713004/200001
6 years, 6 months ago (2014-06-11 21:43:16 UTC) #17
sadrul
ui/base/x lgtm
6 years, 6 months ago (2014-06-11 22:00:32 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:59:29 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 23:01:33 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/149837) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/21934) mac_gpu ...
6 years, 6 months ago (2014-06-11 23:01:34 UTC) #21
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-12 14:07:00 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/320713004/200001
6 years, 6 months ago (2014-06-12 14:09:24 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-12 16:44:09 UTC) #24
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 17:11:05 UTC) #25
Message was sent while issue was closed.
Change committed as 276719

Powered by Google App Engine
This is Rietveld 408576698