Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

Issue 320713003: Fixes crash in view_manager_lib (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc
diff --git a/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc b/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc
index be24cec1828ad1f8092c783d11cb17e0aceb1c77..82a9fd598cba89d7ca114f2dfeb66f67487f6a5a 100644
--- a/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc
+++ b/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc
@@ -447,6 +447,9 @@ ViewManagerSynchronizer::ViewManagerSynchronizer(ViewManagerDelegate* delegate)
}
ViewManagerSynchronizer::~ViewManagerSynchronizer() {
+ // Destroying the |view_manager_| may attempt to add transactions to
+ // |pending_transactions_|. So we need to destroy |view_manager_| first.
+ view_manager_.reset();
}
TransportNodeId ViewManagerSynchronizer::CreateViewTreeNode() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698