Issue 320713003: Fixes crash in view_manager_lib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 320713003: Fixes crash in view_manager_lib (Closed)

Created:
6 years, 6 months ago by sky

Modified:
6 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes crash in view_manager_lib ~ViewManagerSynchronizer destroys the view_manager_. Destroying the view_manager_ may add transactions to pending_transactions_. So, we have to make sure view_manager_ is destroyed first. BUG=365012 TEST=none R=ben@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275730

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/320713003/1

6 years, 6 months ago (2014-06-08 00:06:37 UTC) #3

Message was sent while issue was closed.

Change committed as 275730

Expand Messages | Collapse Messages