Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 320693002: Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (Closed)

Created:
6 years, 6 months ago by Joao da Silva
Modified:
6 years, 6 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (https://codereview.chromium.org/318123002/) Reason for revert: page_runner_unittest.PageRunnerTests.testHandlingOfCrashedTab is failing on the main waterfall after this change: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%283%29/builds/48907 http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/27652 http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/11451 Original issue's description: > Telemetry: Last ditch effort to dump symbols on tab crashes if none are found > > Put this together to find a crash which only happened on telemetry unittest runs on Mac trybots; figured it might be useful for later too. > > R=dtu,tonyg > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275675 TBR=dtu@chromium.org,tonyg@chromium.org,oysteine@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -34 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 1 chunk +18 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Joao da Silva
Created Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none ...
6 years, 6 months ago (2014-06-07 14:07:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/320693002/1
6 years, 6 months ago (2014-06-07 14:08:18 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 14:08:37 UTC) #3
Message was sent while issue was closed.
Change committed as 275678

Powered by Google App Engine
This is Rietveld 408576698