Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 320673002: Printing: Don't build service code when full printing is not enabled. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Printing: Don't build service code when full printing is not enabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 3 chunks +14 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/common_message_generator.h View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
6 years, 6 months ago (2014-06-07 00:18:11 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 6 months ago (2014-06-07 05:20:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/320673002/1
6 years, 6 months ago (2014-06-07 05:21:57 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 08:55:11 UTC) #4
Message was sent while issue was closed.
Change committed as 275657

Powered by Google App Engine
This is Rietveld 408576698