Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 320663002: Change the prototype of ChannelIDSource::GetChannelIDKey() to allow an (Closed)

Created:
6 years, 6 months ago by wtc
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Change the prototype of ChannelIDSource::GetChannelIDKey() to allow an asynchronous implementation. Current ChannelIDSource implementations work in synchronous mode. So QuicCryptoClientStream still calls ChannelIDSource::GetChannelIDKey() as a synchronous function. In a future CL, QuicCryptoClientStream will properly call ChannelIDSource::GetChannelIDKey() as an asynchronous function. Note that ChannelIDSourceForTesting() returns a ChannelIDSource that works in synchronous mode. Merge internal CL: 68399207 R=rch@chromium.org,rtenneti@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275634

Patch Set 1 #

Patch Set 2 : Remove unrelated changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -48 lines) Patch
M net/quic/crypto/channel_id.h View 3 chunks +27 lines, -5 lines 0 comments Download
M net/quic/crypto/channel_id_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/crypto/proof_verifier.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 3 chunks +6 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 4 chunks +6 lines, -22 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_nss.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_openssl.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
wtc
Please review. Ryan: this is the second-to-last CL of the series. You already reviewed the ...
6 years, 6 months ago (2014-06-06 22:16:49 UTC) #1
Ryan Hamilton
lgtm
6 years, 6 months ago (2014-06-06 22:27:02 UTC) #2
ramant (doing other things)
On 2014/06/06 22:27:02, Ryan Hamilton wrote: > lgtm +1. Thanks for doing this.
6 years, 6 months ago (2014-06-06 22:39:04 UTC) #3
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 6 months ago (2014-06-06 22:44:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/320663002/20001
6 years, 6 months ago (2014-06-06 22:44:50 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 02:51:52 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 06:31:29 UTC) #7
Message was sent while issue was closed.
Change committed as 275634

Powered by Google App Engine
This is Rietveld 408576698