Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 320633002: Add an extension override bubble and warning box for proxy extensions. (Closed)

Created:
6 years, 6 months ago by Finnur
Modified:
6 years, 6 months ago
Reviewers:
Devlin, sky, Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, chromium-apps-reviews_chromium.org, tfarina, arv+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add an extension override bubble and warning box for proxy extensions. (2nd attempt, this time with two one-liner test fixes) Also use the browser action highlighting for extensions that have a browser action icon. NOTE: This CL was already green-lighted here: https://codereview.chromium.org/288923004/ BUG=381291 TBR=sky, devlin, dbeam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+840 lines, -227 lines) Patch
M chrome/app/generated_resources.grd View 3 chunks +22 lines, -2 lines 0 comments Download
M chrome/browser/extensions/dev_mode_bubble_controller.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.h View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller_unittest.cc View 19 chunks +292 lines, -73 lines 0 comments Download
M chrome/browser/extensions/ntp_overridden_bubble_controller.cc View 2 chunks +4 lines, -2 lines 0 comments Download
A + chrome/browser/extensions/proxy_overridden_bubble_controller.h View 2 chunks +13 lines, -8 lines 0 comments Download
A chrome/browser/extensions/proxy_overridden_bubble_controller.cc View 1 chunk +217 lines, -0 lines 0 comments Download
M chrome/browser/extensions/settings_api_bubble_controller.cc View 14 chunks +43 lines, -44 lines 0 comments Download
M chrome/browser/extensions/settings_api_helpers.h View 1 chunk +21 lines, -11 lines 0 comments Download
M chrome/browser/extensions/settings_api_helpers.cc View 5 chunks +33 lines, -17 lines 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_controller.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.js View 4 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/view_ids.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.h View 5 chunks +24 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 12 chunks +73 lines, -38 lines 0 comments Download
M chrome/browser/ui/views/settings_api_bubble_helper_views.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_view.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 4 chunks +17 lines, -5 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/extension_prefs.h View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Finnur
The CQ bit was checked by finnur@chromium.org
6 years, 6 months ago (2014-06-06 22:47:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/320633002/1
6 years, 6 months ago (2014-06-06 22:48:22 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 00:44:27 UTC) #3
Message was sent while issue was closed. 
Change committed as 275577

Powered by Google App Engine
This is Rietveld 408576698