Will now copy apprtc to out/ in order to resolve symlinks on Windows.

copy_apprtc.py

Index: copy_apprtc.py
===================================================================
--- copy_apprtc.py	(revision 0)
+++ copy_apprtc.py	(revision 0)
@@ -0,0 +1,19 @@
+#!/usr/bin/python
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Moves Apprtc to the out/ directory, where the browser test can find it.

[Ami GONE FROM CHROMIUM, 2013/10/21 15:01:58]

s/Moves/Copies/

+
+This copy will resolve symlinks on all platforms, which is useful for Apprtc
+since it uses symlinks for its common javascript files (and Windows does not
+understand those symlinks).
+"""
+
+import shutil
+
+
+if __name__ == '__main__':
+  shutil.rmtree('src/out/apprtc', ignore_errors=True);

[Ami GONE FROM CHROMIUM, 2013/10/21 15:01:58]

Neither "src" nor "out" can be hard-coded this way; it is legit for chromium
workspaces to have different names for both of those directories.
This is one reason why we don't usually do this sort of thing as a DEPS hook.

Why are you using a hook instead of making this a gyp action (e.g. like
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...
) ??

[phoglund_chromium, 2013/10/21 15:12:36]

The problem is I don't have a gyp file to put it in. I can't link any apprtc gyp
code into Chrome's gyp graph because apprtc doesn't live in the chromium repo. I
pondered making a separate gyp_chromium invocation in the webrtc.DEPS hooks, but
that seems like it will mess with the regular gyp generation (unless possibly
it's guaranteed to run before the main gyp generation). In general, this
friction arises from the fact that this is an integration test that involves
three code locations.

We don't have to care about whether out/ gets used to put C++ object files in.
The only thing that matters is that it's .gitignor'd and that the browser test
agrees on the location. 

The src name thing is unfortunate though. It will work on the bots and for most
users at least.

+  shutil.copytree('src/third_party/webrtc_apprtc/apprtc',
+                  'src/out/apprtc', ignore=shutil.ignore_patterns('.svn'))
Property changes on: copy_apprtc.py
___________________________________________________________________
Added: svn:eol-style
   + LF
Added: svn:executable
   + *