Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 320583002: Make the destructor of WebFrameClient virtual. (Closed)

Created:
6 years, 6 months ago by dshwang
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make the destructor of WebFrameClient virtual. Most subclasses of WebFrameClient assume that the destructor of WebFrameClient is virtual. Currently, CreateChildCounterFrameClient class in WebViewTest.cpp is in trouble because of this. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M public/web/WebFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dshwang
Could you review?
6 years, 6 months ago (2014-06-06 15:04:20 UTC) #1
pfeldman
lgtm
6 years, 6 months ago (2014-06-06 15:14:51 UTC) #2
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-06 16:59:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/320583002/1
6 years, 6 months ago (2014-06-06 16:59:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-06 18:01:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 18:04:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7192)
6 years, 6 months ago (2014-06-06 18:04:30 UTC) #7
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 6 months ago (2014-06-06 18:07:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/320583002/1
6 years, 6 months ago (2014-06-06 18:08:14 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 18:11:04 UTC) #10
Message was sent while issue was closed.
Change committed as 175685

Powered by Google App Engine
This is Rietveld 408576698