Issue 320573002: Revert of Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 320573002: Revert of Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds. (Closed)

Created:
6 years, 6 months ago by egdaniel

Modified:
6 years, 6 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds. (https://codereview.chromium.org/311373003/) Reason for revert: changed assert is failing Original issue's description: > Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/be4fd4f7349b97a7c34a4177ec26d8aea9616628 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/97724ed4cf5ee29bb6020e50348a84cd2a3bf920

Created: 6 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
	M	src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp	View		4 chunks	+7 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

egdaniel

Created Revert of Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds.

6 years, 6 months ago (2014-06-06 14:46:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/320573002/1

6 years, 6 months ago (2014-06-06 14:47:15 UTC) #2

commit-bot: I haz the power

6 years, 6 months ago (2014-06-06 14:47:21 UTC) #3

Message was sent while issue was closed.

Change committed as 97724ed4cf5ee29bb6020e50348a84cd2a3bf920