Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 320563003: Revert of Faster GPU rect blur that doesn't require computing vertical and horizontal (Closed)

Created:
6 years, 6 months ago by jvanverth1
Modified:
6 years, 6 months ago
Reviewers:
humper, bsalomon
CC:
skia-review_googlegroups.com, ernstm
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Faster GPU rect blur that doesn't require computing vertical and horizontal (https://codereview.chromium.org/316273004/) Reason for revert: Many tree failures in RunTests (looks like GLProgramsTest). Original issue's description: > Faster GPU rect blur that doesn't require computing vertical and horizontal > scanlines on the CPU first. Should make extremely large drop shadows fast > again. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/fe689c46a764ded343e5028f79ead80c8b140b0f TBR=bsalomon@google.com,humper@google.com NOTREECHECKS=true NOTRY=true BUG=skia:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -113 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 8 chunks +101 lines, -104 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvanverth1
Created Revert of Faster GPU rect blur that doesn't require computing vertical and horizontal
6 years, 6 months ago (2014-06-06 18:01:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/320563003/1
6 years, 6 months ago (2014-06-06 18:02:16 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 18:02:17 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 18:02:18 UTC) #4
Failed to apply patch for expectations/gm/ignored-tests.txt:
While running git apply --index -p1;
  error: patch failed: expectations/gm/ignored-tests.txt:38
  error: expectations/gm/ignored-tests.txt: patch does not apply

Patch:       expectations/gm/ignored-tests.txt
Index: expectations/gm/ignored-tests.txt
diff --git a/expectations/gm/ignored-tests.txt
b/expectations/gm/ignored-tests.txt
index
3b5c03a27bdae5e116f54d486450460142349a71..9698dfcdb3839c2a64682a915c630afd6887a44c
100644
--- a/expectations/gm/ignored-tests.txt
+++ b/expectations/gm/ignored-tests.txt
@@ -38,15 +38,6 @@
 # I will likely just delete the GM.
 canvas-layer-state
 
-# humper:
-# Needs rebaselining after faster GPU blur patch lands
-megalooper_0x0
-megalooper_1x4
-megalooper_4x1
-bleed
-blurquickreject
-blurrects
-
 # These are part of picture-version 27 -- removal of SkUnitMapp
 # just need to be rebaselined
 scaled_tilemode_bitmap

Powered by Google App Engine
This is Rietveld 408576698