Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 320553004: Add on-by-default tracing to FrameView::invalidateTree which adds more debug info (Closed)

Created:
6 years, 6 months ago by chrishtr
Modified:
6 years, 6 months ago
Reviewers:
dsinclair, esprehn, ojan
CC:
blink-reviews, esprehn
Visibility:
Public.

Description

Add on-by-default tracing to FrameView::invalidateTree which adds more debug info if the tracing category blink.invalidation is on. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175831

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed. #

Patch Set 3 : Simplified. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/frame/FrameView.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
chrishtr
6 years, 6 months ago (2014-06-06 22:41:37 UTC) #1
ojan
Thinking about this more, I'm really skeptical that this will be too expensive to just ...
6 years, 6 months ago (2014-06-07 02:17:23 UTC) #2
esprehn
https://codereview.chromium.org/320553004/diff/1/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/320553004/diff/1/Source/core/frame/FrameView.cpp#newcode1049 Source/core/frame/FrameView.cpp:1049: debugData = root->debugName().ascii().data(); All you're trying to do is ...
6 years, 6 months ago (2014-06-07 02:20:40 UTC) #3
chrishtr
Ok I went with the simple version.
6 years, 6 months ago (2014-06-09 20:05:02 UTC) #4
ojan
lgtm
6 years, 6 months ago (2014-06-09 21:54:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/320553004/40001
6 years, 6 months ago (2014-06-09 21:55:19 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 23:04:12 UTC) #7
Message was sent while issue was closed.
Change committed as 175831

Powered by Google App Engine
This is Rietveld 408576698