Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 320523004: Timeline: fill frames according to CPU time spent per event category (Closed)

Created:
6 years, 6 months ago by caseq
Modified:
6 years, 6 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Timeline: fill frames according to CPU time spent per event category Also add test for frame model. Note there are still discrepancies wrt how time per category is computed for timeline records -- these will be the subject of a separate patch. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175781

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -123 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 1 chunk +21 lines, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-frame-model.html View 1 chunk +0 lines, -26 lines 0 comments Download
M LayoutTests/inspector/timeline/trace-event-self-time.html View 1 2 chunks +7 lines, -9 lines 0 comments Download
A LayoutTests/inspector/timeline/tracing/frame-model.html View 1 chunk +245 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/timeline/tracing/frame-model-expected.txt View 8 chunks +33 lines, -54 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 1 8 chunks +79 lines, -22 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingModel.js View 1 1 chunk +10 lines, -6 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineUIUtils.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
caseq
6 years, 6 months ago (2014-06-06 15:43:57 UTC) #1
yurys
lgtm
6 years, 6 months ago (2014-06-09 07:26:32 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-09 07:27:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/320523004/20001
6 years, 6 months ago (2014-06-09 07:27:55 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 08:35:06 UTC) #5
Message was sent while issue was closed. 
Change committed as 175781

Powered by Google App Engine
This is Rietveld 408576698