Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 320523002: Add FILE_MISSING in PpapiThread::LoadResult for UMA reporting. (Closed)

Created:
6 years, 6 months ago by xhwang
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org, jar+watch_chromium.org
Visibility:
Public.

Description

Add FILE_MISSING in PpapiThread::LoadResult for UMA reporting. Missing plugin file is a common cause of plugin loading failure. Explictly report this case instead of relying on system error codes. Note that for plugins with dependencies, this only catches the case that the real plugin file is missing. Missing dependencies will still be reported through error codes. One example of this is that the widevinecdmadapter.dll file depends on widevinecdm.dll. BUG=345852 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/ppapi_plugin/ppapi_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
xhwang
PTAL
6 years, 6 months ago (2014-06-06 01:02:24 UTC) #1
ddorwin
lgtm
6 years, 6 months ago (2014-06-06 01:21:48 UTC) #2
xhwang
jar: Please OWNERS review the histogram.xml change. piman: Please OWNERS review content/ppapi_plugin/* My understanding is ...
6 years, 6 months ago (2014-06-06 16:05:26 UTC) #3
piman
lgtm
6 years, 6 months ago (2014-06-09 14:38:33 UTC) #4
jar (doing other things)
histograms.xml lgtm
6 years, 6 months ago (2014-06-09 18:50:28 UTC) #5
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 6 months ago (2014-06-09 21:07:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/320523002/1
6 years, 6 months ago (2014-06-09 21:08:45 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 11:14:13 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 16:31:24 UTC) #9
Message was sent while issue was closed.
Change committed as 276052

Powered by Google App Engine
This is Rietveld 408576698