Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 320503005: Push API: define push event on Service Worker. (Closed)

Created:
6 years, 6 months ago by Michael van Ouwerkerk
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -4 lines) Patch
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/EventTypeNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/modules.gypi View 4 chunks +6 lines, -0 lines 0 comments Download
A Source/modules/push_messaging/PushEvent.h View 1 chunk +51 lines, -0 lines 0 comments Download
A Source/modules/push_messaging/PushEvent.cpp View 1 chunk +42 lines, -0 lines 0 comments Download
A + Source/modules/push_messaging/PushEvent.idl View 1 chunk +3 lines, -2 lines 0 comments Download
A Source/modules/push_messaging/ServiceWorkerGlobalScopePush.h View 1 chunk +19 lines, -0 lines 0 comments Download
A + Source/modules/push_messaging/ServiceWorkerGlobalScopePush.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M public/web/WebServiceWorkerContextProxy.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael van Ouwerkerk
The CQ bit was checked by mvanouwerkerk@chromium.org
6 years, 6 months ago (2014-06-06 15:24:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/320503005/1
6 years, 6 months ago (2014-06-06 15:25:50 UTC) #2
Peter Beverloo
On 2014/06/06 15:25:50, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 6 months ago (2014-06-06 15:27:30 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-06 15:28:01 UTC) #4
commit-bot: I haz the power
Change committed as 175672
6 years, 6 months ago (2014-06-06 15:30:53 UTC) #5
Michael van Ouwerkerk
I checked the changes but there doesn't seem anything wrong with them. I couldn't find ...
6 years, 6 months ago (2014-06-06 15:31:56 UTC) #6
vsevik
6 years, 6 months ago (2014-06-06 17:11:02 UTC) #7
Message was sent while issue was closed.
On 2014/06/06 15:31:56, Michael van Ouwerkerk wrote:
> I checked the changes but there doesn't seem anything wrong with them. I
> couldn't find any recent build changes that would affect EventTypeNames. The
try
> bots seem fine. It builds locally. It seems worth another try, considering the
> flakiness of our systems :-/

I am getting compile failure locally now.
Couldn't it be some dependencies problem?

Powered by Google App Engine
This is Rietveld 408576698