Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 320493002: Navigation transitions: Expose documentLoadedInFrame to WebContentsObserverAndroid. (Closed)

Created:
6 years, 6 months ago by shatch
Modified:
6 years, 6 months ago
Reviewers:
Ted C, Sami
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Navigation transitions: Expose documentLoadedInFrame to WebContentsObserverAndroid. The TransitionPageHelper in the embedder listens for this before fading out the transition layer. Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 BUG=370696 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M content/browser/android/web_contents_observer_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/android/web_contents_observer_android.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
shatch
6 years, 6 months ago (2014-06-05 21:38:17 UTC) #1
Sami
lgtm.
6 years, 6 months ago (2014-06-06 17:47:32 UTC) #2
shatch
The CQ bit was checked by simonhatch@chromium.org
6 years, 6 months ago (2014-06-06 18:25:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/320493002/1
6 years, 6 months ago (2014-06-06 18:27:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 21:43:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 21:49:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/72263)
6 years, 6 months ago (2014-06-06 21:49:06 UTC) #7
shatch
Removing bulach at his request. Hi Ted, looking for a reviewer for the content/public/android part, ...
6 years, 6 months ago (2014-06-10 16:55:55 UTC) #8
Ted C
lgtm
6 years, 6 months ago (2014-06-10 17:01:29 UTC) #9
shatch
The CQ bit was checked by simonhatch@chromium.org
6 years, 6 months ago (2014-06-10 17:03:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/320493002/1
6 years, 6 months ago (2014-06-10 17:05:04 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 17:49:12 UTC) #12
Message was sent while issue was closed. 
Change committed as 276065

Powered by Google App Engine
This is Rietveld 408576698