Added the "unmodifiable" property to chrome.bookmarks.BookmarkTreeNode.

chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_BOOKMARKS_BOOKMARK_API_HELPERS_H_
 #define CHROME_BROWSER_EXTENSIONS_API_BOOKMARKS_BOOKMARK_API_HELPERS_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "chrome/common/extensions/api/bookmarks.h"
 
 class BookmarkModel;
 class BookmarkNode;
 class ChromeBookmarkClient;
 
 // Helper functions.
 namespace extensions {
 namespace bookmark_api_helpers {
 
 // The returned value is owned by the caller.
 api::bookmarks::BookmarkTreeNode* GetBookmarkTreeNode(
+    ChromeBookmarkClient* client,

[not at google - send to devlin, 2014/06/05 20:58:26]

well one way you could "fix" this is by making this a class, not a set of utils,
which take a ChromeBookmarkClient in its constructor.. then constructing one for
each bookmarks API call.

might be overkill for this change though.

[Joao da Silva, 2014/06/05 21:04:16]

I think I'll leave this change as-is to be focused just on the API.

WDYT of moving these 4 helpers to the ChromeBookmarkClient itself?

[not at google - send to devlin, 2014/06/05 22:21:32]

The functions which deal with Extension-generated objects (like
BookmarkTreeNode) don't really belong on ChromeBookmarkClient. Better for
ChromeBookmarkClient to be ignorant of anything extensiony.

[Joao da Silva, 2014/06/05 22:28:23]

Makes sense.

These helpers are only used by the implementations of bookmarks and
bookmarkManagerPrivate APIs, and all of them inherit from BookmarksFunction.
BookmarksFunction already has some protected helpers, so WDYT of removing this
file and moving these helpers into methods of that class?

[not at google - send to devlin, 2014/06/05 22:29:10]

SVGTM.

     const BookmarkNode* node,
     bool recurse,
     bool only_folders);
 
 // Add a JSON representation of |node| to the JSON |nodes|.
-void AddNode(const BookmarkNode* node,
+void AddNode(ChromeBookmarkClient* client,
+             const BookmarkNode* node,
              std::vector<linked_ptr<api::bookmarks::BookmarkTreeNode> >* nodes,
              bool recurse);
 
-void AddNodeFoldersOnly(const BookmarkNode* node,
+void AddNodeFoldersOnly(ChromeBookmarkClient* client,
+                        const BookmarkNode* node,
                         std::vector<linked_ptr<
                             api::bookmarks::BookmarkTreeNode> >* nodes,
                         bool recurse);
 
 bool RemoveNode(ChromeBookmarkClient* client,
                 int64 id,
                 bool recursive,
                 std::string* error);
 
 }  // namespace bookmark_api_helpers
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_BOOKMARKS_BOOKMARK_API_HELPERS_H_