Bluetooth: Implement socket API for Windows.

Bluetooth: Implement socket API for Windows.

- BluetoothSocketWin::StartService -> BluetoothSocketWin::Listen;
- Update BluetoothSocketWin::Connect to use a new semantics;
- Impelment BluetoothDeviceWin::ConnectToService and
  BluetoothAdapterWin::CreateRfcommService using the above two;
- Remove no longer needed BluetoothProfileWin;

BUG=372494
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275394

[xiyuan, 2014-06-05 20:01:11]

It is quite straightforward and easier than I expected. :)

[rpaquay, 2014-06-05 20:40:36]

lgtm with a question below.

https://codereview.chromium.org/320463002/diff/10001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_socket_win.cc (right):

https://codereview.chromium.org/320463002/diff/10001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_socket_win.cc:115: device->GetServiceRecord(uuid));
Don't we need to check to NULL here? Or, if we are certain uuid is a known
service, maybe add a DCHECK?

[xiyuan, 2014-06-05 20:57:23]

https://codereview.chromium.org/320463002/diff/10001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_socket_win.cc (right):

https://codereview.chromium.org/320463002/diff/10001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_socket_win.cc:115: device->GetServiceRecord(uuid));
On 2014/06/05 20:40:36, rpaquay wrote:
> Don't we need to check to NULL here? Or, if we are certain uuid is a known
> service, maybe add a DCHECK?

Absolutely needed, missed that. Handled as an invalid uuid error now.

[keybuk, 2014-06-05 22:03:03]

lgtm

https://codereview.chromium.org/320463002/diff/30001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_socket_win.cc (right):

https://codereview.chromium.org/320463002/diff/30001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_socket_win.cc:114: const BluetoothServiceRecord*
service_record = device->GetServiceRecord(uuid);
If this returned BluetoothServiceRecordWin* directly...

https://codereview.chromium.org/320463002/diff/30001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_socket_win.cc:121: static_cast<const
BluetoothServiceRecordWin*>(service_record);
...then you wouldn't need to cast it here.

[xiyuan, 2014-06-06 00:29:13]

https://codereview.chromium.org/320463002/diff/30001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_socket_win.cc (right):

https://codereview.chromium.org/320463002/diff/30001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_socket_win.cc:121: static_cast<const
BluetoothServiceRecordWin*>(service_record);
On 2014/06/05 22:03:03, keybuk wrote:
> ...then you wouldn't need to cast it here.

Done.

[xiyuan, 2014-06-06 00:29:33]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-06-06 00:31:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xiyuan@chromium.org/320463002/50001

[commit-bot: I haz the power, 2014-06-06 11:03:43]

Change committed as 275394