Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 320453002: Update layout tests for touch text selection. (Closed)

Created:
6 years, 6 months ago by Zeeshan Qureshi
Modified:
6 years, 6 months ago
Reviewers:
mohsen, Rick Byers
CC:
blink-reviews
Visibility:
Public.

Description

Touch text selection is going to be enabled on aura and these layout tests needed to be updated. Long press on text will no longer show a context menu. BUG=381152 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M LayoutTests/fast/events/touch/gesture/context-menu-on-long-press.html View 2 chunks +10 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/context-menu-on-long-press-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Zeeshan Qureshi
6 years, 6 months ago (2014-06-05 20:23:08 UTC) #1
Rick Byers
LGTM, thanks!
6 years, 6 months ago (2014-06-05 20:56:47 UTC) #2
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 6 months ago (2014-06-05 20:57:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/320453002/1
6 years, 6 months ago (2014-06-05 20:58:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-05 22:13:04 UTC) #5
Zeeshan Qureshi
The CQ bit was unchecked by zeeshanq@chromium.org
6 years, 6 months ago (2014-06-05 22:43:51 UTC) #6
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 6 months ago (2014-06-05 22:43:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/320453002/1
6 years, 6 months ago (2014-06-05 22:43:58 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 22:47:45 UTC) #9
Message was sent while issue was closed.
Change committed as 175595

Powered by Google App Engine
This is Rietveld 408576698