Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 320443002: remove GM result-grooming tools that use skia-autogen (Closed)

Created:
6 years, 6 months ago by epoger
Modified:
6 years, 6 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com, senorblanco, bsalomon, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

remove GM result-grooming tools that use skia-autogen BUG=skia:553 Committed: https://skia.googlesource.com/skia/+/89e884282143e06a9cd2ececcd45642b8d69ab30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10777 lines) Patch
D gm/show_gm_changes.py View 1 chunk +0 lines, -117 lines 0 comments Download
D gm/viewer/base-android-nexus-10/Test-Android-Nexus10-MaliT604-Arm7-Release/base-android-nexus-10/actual-results.json View 1 chunk +0 lines, -5427 lines 0 comments Download
D gm/viewer/base-fake/Fake-Platform-Made-Up/base-fake/actual-results.json View 1 chunk +0 lines, -4375 lines 0 comments Download
D gm/viewer/module.js View 1 chunk +0 lines, -75 lines 0 comments Download
D gm/viewer/view.html View 1 chunk +0 lines, -51 lines 0 comments Download
D tools/rebaseline.py View 1 chunk +0 lines, -506 lines 0 comments Download
D tools/roll_autogen.sh View 1 chunk +0 lines, -64 lines 0 comments Download
D tools/verify_images_for_gm_results.py View 1 chunk +0 lines, -162 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
epoger
We are on the verge of deleting our skia-autogen SVN repo (where we have stored ...
6 years, 6 months ago (2014-06-05 19:33:38 UTC) #1
borenet
LGTM if we're sure none of these are needed.
6 years, 6 months ago (2014-06-05 19:49:58 UTC) #2
epoger
On 2014/06/05 19:49:58, borenet wrote: > LGTM if we're sure none of these are needed. ...
6 years, 6 months ago (2014-06-05 20:19:47 UTC) #3
Stephen White
On 2014/06/05 20:19:47, epoger wrote: > On 2014/06/05 19:49:58, borenet wrote: > > LGTM if ...
6 years, 6 months ago (2014-06-05 20:24:48 UTC) #4
epoger
On 2014/06/05 20:24:48, Stephen White wrote: > On 2014/06/05 20:19:47, epoger wrote: > > On ...
6 years, 6 months ago (2014-06-05 20:27:53 UTC) #5
Stephen White
On 2014/06/05 20:27:53, epoger wrote: > On 2014/06/05 20:24:48, Stephen White wrote: > > On ...
6 years, 6 months ago (2014-06-05 20:37:07 UTC) #6
epoger
The CQ bit was checked by epoger@google.com
6 years, 6 months ago (2014-06-09 13:17:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/320443002/1
6 years, 6 months ago (2014-06-09 13:18:51 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 13:49:18 UTC) #9
Message was sent while issue was closed.
Change committed as 89e884282143e06a9cd2ececcd45642b8d69ab30

Powered by Google App Engine
This is Rietveld 408576698