ipc/ipc_channel_posix.cc - Issue 320433002: IPC::Channel: Reduce POSIX specific API surface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_posix.cc

Issue 320433002: IPC::Channel: Reduce POSIX specific API surface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_channel_posix.cc

diff --git a/ipc/ipc_channel_posix.cc b/ipc/ipc_channel_posix.cc

index 3972788772eed771ecc1b3df6250492e4fece7dd..d23b82128fac31ca1e578ade8f4262e3ca72d629 100644

--- a/ipc/ipc_channel_posix.cc

+++ b/ipc/ipc_channel_posix.cc

@@ -1056,8 +1056,7 @@ base::ProcessId ChannelPosix::GetPeerPID() const {

// static

scoped_ptr<Channel> Channel::Create(

const IPC::ChannelHandle &channel_handle, Mode mode, Listener* listener) {

- return scoped_ptr<Channel>(

- new ChannelPosix(channel_handle, mode, listener));

+ return ChannelPosix::Create(channel_handle, mode, listener).PassAs<Channel>();

jam 2014/06/06 14:47:13 nit: i think you forgot to update this

}

// static