Issue 32043003: Replace kChromeOSReleaseBoard with SysInfo::GetLsbReleaseBoard()

Issue 32043003: Replace kChromeOSReleaseBoard with SysInfo::GetLsbReleaseBoard() (Closed)

Created:
7 years, 2 months ago by stevenjb

Modified:
7 years, 1 month ago

Reviewers:
keybuk, Raghu Simha

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, rsimha+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replace kChromeOSReleaseBoard with SysInfo::GetLsbReleaseBoard() BUG=126732 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231396

Patch Set 1 #

Patch Set 2 : Fix DEPS #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -62 lines)			Patch
M	chromeos/chromeos_switches.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/chromeos_switches.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	device/bluetooth/bluetooth_adapter_chromeos.cc	View		2 chunks	+2 lines, -12 lines	0 comments	Download
M	sync/util/DEPS	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	sync/util/get_session_name.cc	View		2 chunks	+2 lines, -25 lines	0 comments	Download
M	sync/util/get_session_name_unittest.cc	View		3 chunks	+5 lines, -18 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

stevenjb

This is some cleanup associated with having addressed crbug.com/266903

7 years, 2 months ago (2013-10-22 01:02:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/32043003/1

7 years, 2 months ago (2013-10-25 00:31:38 UTC) #5

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=181140

7 years, 2 months ago (2013-10-25 02:00:01 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/32043003/330001

7 years, 1 month ago (2013-10-28 17:30:59 UTC) #7

Message was sent while issue was closed.

Change committed as 231396

Expand Messages | Collapse Messages