Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: remoting/client/log_to_server_client.cc

Issue 320403002: Pull out common code from client and host versions of LogToServer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/log_to_server_client.cc
diff --git a/remoting/client/log_to_server.cc b/remoting/client/log_to_server_client.cc
similarity index 59%
rename from remoting/client/log_to_server.cc
rename to remoting/client/log_to_server_client.cc
index e29de13584babf3a25cc8cf46d6c87a54063303d..b4c2aa889a274ab569fe2c95473e48229927f20a 100644
--- a/remoting/client/log_to_server.cc
+++ b/remoting/client/log_to_server_client.cc
@@ -2,20 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "remoting/client/log_to_server.h"
+#include "remoting/client/log_to_server_client.h"
#include "base/macros.h"
#include "base/rand_util.h"
-#include "remoting/base/constants.h"
#include "remoting/client/chromoting_stats.h"
#include "remoting/client/server_log_entry_client.h"
-#include "remoting/jingle_glue/iq_sender.h"
-#include "remoting/jingle_glue/signal_strategy.h"
-#include "third_party/libjingle/source/talk/xmllite/xmlelement.h"
-#include "third_party/libjingle/source/talk/xmpp/constants.h"
-using buzz::QName;
-using buzz::XmlElement;
using remoting::protocol::ConnectionToHost;
namespace {
@@ -49,22 +42,16 @@ bool ShouldAddDuration(ConnectionToHost::State state) {
namespace remoting {
-namespace client {
-
-LogToServer::LogToServer(ServerLogEntry::Mode mode,
- SignalStrategy* signal_strategy,
- const std::string& directory_bot_jid)
- : mode_(mode),
- signal_strategy_(signal_strategy),
- directory_bot_jid_(directory_bot_jid) {
- signal_strategy_->AddListener(this);
+LogToServerClient::LogToServerClient(ServerLogEntry::Mode mode,
+ SignalStrategy* signal_strategy,
+ const std::string& directory_bot_jid)
+ : LogToServer(mode, signal_strategy, directory_bot_jid) {
}
-LogToServer::~LogToServer() {
- signal_strategy_->RemoveListener(this);
+LogToServerClient::~LogToServerClient() {
}
-void LogToServer::LogSessionStateChange(
+void LogToServerClient::LogSessionStateChange(
protocol::ConnectionToHost::State state,
protocol::ErrorCode error) {
DCHECK(CalledOnValidThread());
@@ -72,7 +59,7 @@ void LogToServer::LogSessionStateChange(
scoped_ptr<ServerLogEntry> entry(
MakeLogEntryForSessionStateChange(state, error));
AddClientFieldsToLogEntry(entry.get());
- entry->AddModeField(mode_);
+ entry->AddModeField(mode());
MaybeExpireSessionId();
if (IsStartOfSession(state)) {
@@ -103,62 +90,19 @@ void LogToServer::LogSessionStateChange(
Log(*entry.get());
}
-void LogToServer::LogStatistics(ChromotingStats* statistics) {
+void LogToServerClient::LogStatistics(ChromotingStats* statistics) {
DCHECK(CalledOnValidThread());
MaybeExpireSessionId();
scoped_ptr<ServerLogEntry> entry(MakeLogEntryForStatistics(statistics));
AddClientFieldsToLogEntry(entry.get());
- entry->AddModeField(mode_);
+ entry->AddModeField(mode());
AddSessionIdToLogEntry(entry.get(), session_id_);
Log(*entry.get());
}
-void LogToServer::OnSignalStrategyStateChange(SignalStrategy::State state) {
- DCHECK(CalledOnValidThread());
-
- if (state == SignalStrategy::CONNECTED) {
- iq_sender_.reset(new IqSender(signal_strategy_));
- SendPendingEntries();
- } else if (state == SignalStrategy::DISCONNECTED) {
- iq_sender_.reset();
- }
-}
-
-bool LogToServer::OnSignalStrategyIncomingStanza(
- const buzz::XmlElement* stanza) {
- return false;
-}
-
-void LogToServer::Log(const ServerLogEntry& entry) {
- pending_entries_.push_back(entry);
- SendPendingEntries();
-}
-
-void LogToServer::SendPendingEntries() {
- if (iq_sender_ == NULL) {
- return;
- }
- if (pending_entries_.empty()) {
- return;
- }
- // Make one stanza containing all the pending entries.
- scoped_ptr<XmlElement> stanza(ServerLogEntry::MakeStanza());
- while (!pending_entries_.empty()) {
- ServerLogEntry& entry = pending_entries_.front();
- stanza->AddElement(entry.ToStanza().release());
- pending_entries_.pop_front();
- }
- // Send the stanza to the server.
- scoped_ptr<IqRequest> req = iq_sender_->SendIq(
- buzz::STR_SET, directory_bot_jid_, stanza.Pass(),
- IqSender::ReplyCallback());
- // We ignore any response, so let the IqRequest be destroyed.
- return;
-}
-
-void LogToServer::GenerateSessionId() {
+void LogToServerClient::GenerateSessionId() {
session_id_.resize(kSessionIdLength);
for (int i = 0; i < kSessionIdLength; i++) {
const int alphabet_size = arraysize(kSessionIdAlphabet) - 1;
@@ -167,7 +111,7 @@ void LogToServer::GenerateSessionId() {
session_id_generation_time_ = base::TimeTicks::Now();
}
-void LogToServer::MaybeExpireSessionId() {
+void LogToServerClient::MaybeExpireSessionId() {
if (session_id_.empty()) {
return;
}
@@ -176,7 +120,7 @@ void LogToServer::MaybeExpireSessionId() {
if (base::TimeTicks::Now() - session_id_generation_time_ > max_age) {
// Log the old session ID.
scoped_ptr<ServerLogEntry> entry(MakeLogEntryForSessionIdOld(session_id_));
- entry->AddModeField(mode_);
+ entry->AddModeField(mode());
Log(*entry.get());
// Generate a new session ID.
@@ -184,11 +128,9 @@ void LogToServer::MaybeExpireSessionId() {
// Log the new session ID.
entry = MakeLogEntryForSessionIdNew(session_id_);
- entry->AddModeField(mode_);
+ entry->AddModeField(mode());
Log(*entry.get());
}
}
-} // namespace client
-
} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698