Issue 3204007: Make tabOverlap dynamic depending on the number of non-mini tabs presented on...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3204007: Make tabOverlap dynamic depending on the number of non-mini tabs presented on... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Pencilcheck

Modified:
3 years, 10 months ago

Reviewers:
Glen Murphy, Andrew Bonventre (Bons)

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Make tabOverlap dynamic depending on the number of non-mini tabs presented on the tab strip to address the bug at htp://crbug.com/188. Also added fisheye tabs which will increase size temporarily when hovered without being selected. Users would be able to read the title of the hovered tab when the strip can't hold more tabs with default tab overlap size. from Penn Su <pennsu@gmail.com>; BUG=52213 TEST=none

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -16 lines)			Patch
M	AUTHORS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/tab_controller.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/tab_controller.mm	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/tab_strip_controller.mm	View	11 chunks	+42 lines, -15 lines	0 comments	Download
M	chrome/browser/cocoa/tab_view.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/tab_view.mm	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Trybot results:

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Pencilcheck

4 years, 9 months ago (2010-08-25 20:43:38 UTC) #1

This is my first attempt to address the problem of tab overflow in a window with
limited space.

Expand Messages | Collapse Messages