Close the bubble when entering full screen

chrome/browser/ui/cocoa/base_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/string_util.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 @interface BaseBubbleController (Private)
 - (void)registerForNotifications;
 - (void)updateOriginFromAnchor;
 - (void)activateTabWithContents:(content::WebContents*)newContents
                previousContents:(content::WebContents*)oldContents
                         atIndex:(NSInteger)index
                          reason:(int)reason;
 - (void)recordAnchorOffset;
 - (void)parentWindowDidResize:(NSNotification*)notification;
 - (void)parentWindowWillClose:(NSNotification*)notification;
+- (void)parentWindowWillBecomeFullScreen:(NSNotification*)notification;
 - (void)closeCleanup;
 @end
 
 @implementation BaseBubbleController
 
 @synthesize parentWindow = parentWindow_;
 @synthesize anchorPoint = anchor_;
 @synthesize bubble = bubble_;
 @synthesize shouldOpenAsKeyWindow = shouldOpenAsKeyWindow_;
 @synthesize shouldCloseOnResignKey = shouldCloseOnResignKey_;
@@ skipping 74 matching lines @@
   [super dealloc];
 }
 
 - (void)registerForNotifications {
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
   // Watch to see if the parent window closes, and if so, close this one.
   [center addObserver:self
              selector:@selector(parentWindowWillClose:)
                  name:NSWindowWillCloseNotification
                object:parentWindow_];
+  // Watch for the full screen event, if so, close the bubble
+  [center addObserver:self
+             selector:@selector(parentWindowWillBecomeFullScreen:)
+                 name:NSWindowWillEnterFullScreenNotification

[Robert Sesek, 2014/06/11 15:03:54]

This notification is only available on 10.7 and later, but Chrome needs to
support 10.6. 

Move the definition of this notification here:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

... into base/mac/sdk_forward_declarations.h. You'll need to create a new .mm
file to place the string value, though. So in the .h:

extern NSString* const NSWindowDidExitFullScreenNotification;

In the new .mm file:

NSString* const NSWindowDidExitFullScreenNotification =
@"NSWindowDidExitFullScreenNotification";

+               object:parentWindow_];
   // Watch for parent window's resizing, to ensure this one is always
   // anchored correctly.
   [center addObserver:self
              selector:@selector(parentWindowDidResize:)
                  name:NSWindowDidResizeNotification
                object:parentWindow_];
 }
 
 - (void)setAnchorPoint:(NSPoint)anchor {
   anchor_ = anchor;
@@ skipping 12 matching lines @@
 - (NSBox*)separatorWithFrame:(NSRect)frame {
   frame.size.height = 1.0;
   base::scoped_nsobject<NSBox> spacer([[NSBox alloc] initWithFrame:frame]);
   [spacer setBoxType:NSBoxSeparator];
   [spacer setBorderType:NSLineBorder];
   [spacer setAlphaValue:0.2];
   return [spacer.release() autorelease];
 }
 
 - (void)parentWindowDidResize:(NSNotification*)notification {
+  if (!parentWindow_)
+    return;
+
   DCHECK_EQ(parentWindow_, [notification object]);
   NSPoint newOrigin = NSMakePoint(NSMinX([parentWindow_ frame]),
                                   NSMaxY([parentWindow_ frame]));
   newOrigin.x -= anchorOffset_.x;
   newOrigin.y -= anchorOffset_.y;
   [self setAnchorPoint:newOrigin];
 }
 
 - (void)parentWindowWillClose:(NSNotification*)notification {
   parentWindow_ = nil;
   [self close];
 }
 
+- (void)parentWindowWillBecomeFullScreen:(NSNotification*)notification {
+  parentWindow_ = nil;
+  [self close];
+}
+
 - (void)closeCleanup {
   if (eventTap_) {
     [NSEvent removeMonitor:eventTap_];
     eventTap_ = nil;
   }
   if (resignationObserver_) {
     [[NSNotificationCenter defaultCenter]
         removeObserver:resignationObserver_
                   name:NSWindowDidResignKeyNotification
                 object:nil];
@@ skipping 150 matching lines @@
 
 - (void)activateTabWithContents:(content::WebContents*)newContents
                previousContents:(content::WebContents*)oldContents
                         atIndex:(NSInteger)index
                          reason:(int)reason {
   // The user switched tabs; close.
   [self close];
 }
 
 @end  // BaseBubbleController