Issue 320343002: Mojo: Make default Options directly accessible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 320343002: Mojo: Make default Options directly accessible. (Closed)

Created:
6 years, 6 months ago by viettrungluu

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Make default Options directly accessible. (So tests don't have to run the validation method to get the default.) R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275881

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -53 lines)			Patch
M	mojo/system/data_pipe.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	mojo/system/data_pipe.cc	View	1 chunk	+10 lines, -8 lines	0 comments	Download
M	mojo/system/shared_buffer_dispatcher.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	mojo/system/shared_buffer_dispatcher.cc	View	1 chunk	+8 lines, -5 lines	0 comments	Download
M	mojo/system/shared_buffer_dispatcher_unittest.cc	View	5 chunks	+19 lines, -40 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 6 months ago (2014-06-10 00:03:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r275881 (presubmit successful).

Expand Messages | Collapse Messages