Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 32033002: Fis crash https://code.google.com/p/dart/issues/detail?id=14242, by calling resolveArguments on the… (Closed)

Created:
7 years, 2 months ago by ngeoffray
Modified:
7 years, 2 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fis crash https://code.google.com/p/dart/issues/detail?id=14242, by calling resolveArguments on the arguments of a SendSet, instead of a raw NodeList visit. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=28924

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart View 1 chunk +4 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/issue14242_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 2 months ago (2013-10-21 09:09:20 UTC) #1
Johnni Winther
lgtm
7 years, 2 months ago (2013-10-21 09:17:44 UTC) #2
ngeoffray
7 years, 2 months ago (2013-10-21 09:31:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698