Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc

Issue 320323003: Enforce "override bookmarks UI" manifest permissions for bookmark shortcut overrides (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stars-remove-settings-overrides-key
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
diff --git a/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc b/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
index 5e387da6909acf1b82ab1ded681f262dbae0ddec..1f8b6cd0a469dcb691d17bdb81084b1b2b454f11 100644
--- a/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
+++ b/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
@@ -184,7 +184,9 @@ bool UIOverridesHandler::Parse(Extension* extension, base::string16* error) {
UIOverrides* assigned_ui_overrides = info.get();
extension->SetManifestData(manifest_keys::kUIOverride, info.release());
assigned_ui_overrides->manifest_permission.reset(new ManifestPermissionImpl(
- UIOverrides::RemovesBookmarkButton(extension)));
+ UIOverrides::RemovesBookmarkButton(extension) ||
+ UIOverrides::RemovesBookmarkShortcut(extension) ||
+ UIOverrides::RemovesBookmarkOpenPagesShortcut(extension)));
not at google - send to devlin 2014/06/09 18:16:28 can this basically be info->bookmarks_ui.get() (i.
Mike Wittman 2014/06/09 19:57:34 Yes, I think so. Changed.
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698