Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 320323003: Enforce "override bookmarks UI" manifest permissions for bookmark shortcut overrides (Closed)

Created:
6 years, 6 months ago by Mike Wittman
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@stars-remove-settings-overrides-key
Visibility:
Public.

Description

Enforce "override bookmarks UI" manifest permissions for bookmark shortcut overrides BUG=382564 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277849

Patch Set 1 #

Total comments: 2

Patch Set 2 : check bookmarks_ui property #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike Wittman
6 years, 6 months ago (2014-06-09 18:11:56 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/320323003/diff/1/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc File chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc (right): https://codereview.chromium.org/320323003/diff/1/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc#newcode189 chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc:189: UIOverrides::RemovesBookmarkOpenPagesShortcut(extension))); can this basically be info->bookmarks_ui.get() (i.e. just "true" ...
6 years, 6 months ago (2014-06-09 18:16:28 UTC) #2
Mike Wittman
https://codereview.chromium.org/320323003/diff/1/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc File chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc (right): https://codereview.chromium.org/320323003/diff/1/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc#newcode189 chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc:189: UIOverrides::RemovesBookmarkOpenPagesShortcut(extension))); On 2014/06/09 18:16:28, kalman wrote: > can this ...
6 years, 6 months ago (2014-06-09 19:57:34 UTC) #3
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-06-09 20:40:25 UTC) #4
Mike Wittman
The CQ bit was checked by wittman@chromium.org
6 years, 6 months ago (2014-06-17 16:53:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/320323003/20001
6 years, 6 months ago (2014-06-17 16:54:18 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 20:26:46 UTC) #7
Message was sent while issue was closed. 
Change committed as 277849

Powered by Google App Engine
This is Rietveld 408576698