Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 320323002: Move CSSStickyPosition back to status=test (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
jamesr, ojan
CC:
blink-reviews, esprehn, ostap
Visibility:
Public.

Description

Move CSSStickyPosition back to status=test We're not actively working on CSSStickyPosition. It's not ready for web developers to experiment with yet. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175816

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove stray change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-09 18:06:54 UTC) #1
jamesr
lgtm https://codereview.chromium.org/320323002/diff/1/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/320323002/diff/1/Source/platform/RuntimeEnabledFeatures.in#newcode32 Source/platform/RuntimeEnabledFeatures.in:32: ClientHintsDpr status=test is this the same thing, or ...
6 years, 6 months ago (2014-06-09 18:07:45 UTC) #2
ojan
The stick position change lgtm. https://codereview.chromium.org/320323002/diff/1/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (left): https://codereview.chromium.org/320323002/diff/1/Source/platform/RuntimeEnabledFeatures.in#oldcode32 Source/platform/RuntimeEnabledFeatures.in:32: ClientHintsDpr status=experimental Did you ...
6 years, 6 months ago (2014-06-09 18:08:20 UTC) #3
ojan
6 years, 6 months ago (2014-06-09 18:09:55 UTC) #4
abarth-chromium
Oops! Will fix.
6 years, 6 months ago (2014-06-09 18:23:18 UTC) #5
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-09 18:24:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/320323002/20001
6 years, 6 months ago (2014-06-09 18:25:26 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 19:27:58 UTC) #8
Message was sent while issue was closed. 
Change committed as 175816

Powered by Google App Engine
This is Rietveld 408576698