Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2825)

Unified Diff: ash/wm/overview/window_selector.h

Issue 320303002: Added UMA stats to overview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overview/window_selector.h
diff --git a/ash/wm/overview/window_selector.h b/ash/wm/overview/window_selector.h
index d6c85195ca1e66a59954c189483fa87222f0e6f3..0f4f65501df903dd73c16c1d34c8f66121965236 100644
--- a/ash/wm/overview/window_selector.h
+++ b/ash/wm/overview/window_selector.h
@@ -66,6 +66,9 @@ class ASH_EXPORT WindowSelector
// Called when the last window selector item from a grid is deleted.
void OnGridEmpty(WindowGrid* grid);
+ // Called when removing a window, adds one to the closed window counter.
+ void on_window_removed() { num_closed_items_++; }
+
// ui::EventHandler:
virtual void OnKeyEvent(ui::KeyEvent* event) OVERRIDE;
@@ -124,9 +127,6 @@ class ASH_EXPORT WindowSelector
// List of all the window overview grids, one for each root window.
ScopedVector<WindowGrid> grid_list_;
- // The time when overview was started.
- base::Time overview_start_time_;
-
// Tracks windows which were hidden because they were not part of the
// overview.
aura::WindowTracker hidden_windows_;
@@ -134,6 +134,18 @@ class ASH_EXPORT WindowSelector
// Tracks the index of the root window the selection widget is in.
size_t selected_grid_index_;
+ // The time when overview was started.
+ base::Time overview_start_time_;
tdanderson 2014/06/09 17:50:46 Similar to my other comment, it might be good to i
Nina 2014/06/09 18:12:50 Done.
+
+ // The number of arrow key presses for this particular overview session.
+ size_t num_key_presses_;
+
+ // The number of items in the overview.
+ size_t num_items_;
+
+ // The number of items that were removed from the overview.
tdanderson 2014/06/09 17:50:46 Similar to |num_key_presses_|, clarify that this c
Nina 2014/06/09 18:12:50 I clarified this with a general comment.
+ size_t num_closed_items_;
+
DISALLOW_COPY_AND_ASSIGN(WindowSelector);
};

Powered by Google App Engine
This is Rietveld 408576698