Chromium Code Reviews Chromium Code Reviews
Issue 320303002:
Added UMA stats to overview mode (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 2cb8740a3307b6a262801375dcc437ec0de9b5b0..d373a03d8b7821ac80cb59e563e55d2fa7aa65d3 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -682,7 +682,7 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| -<histogram name="Ash.WindowSelector.CycleTime" units="milliseconds"> |
| +<histogram name="Ash.WindowCycleController.CycleTime" units="milliseconds"> |
| <owner>flackr@chromium.org</owner> |
| <owner>kuscher@google.com</owner> |
| <summary> |
| @@ -691,23 +691,45 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Ash.WindowSelector.ArrowKeyPresses"> |
| + <owner>flackr@chromium.org</owner> |
| + <owner>tdanderson@chromium.org</owner> |
|
tdanderson
2014/06/09 17:50:46
Get Rob's feedback on this, but I suspect you'll w
Nina
2014/06/09 18:12:51
Rob was the one that suggested adding you. I'm sor
|
| + <summary> |
| + The number of times the arrow keys are pressed in overview mode. This is |
| + only measured for the sessions that end by selecting a window with the enter |
| + key. |
|
tdanderson
2014/06/09 17:50:46
Specify that the count recorded represents the num
Nina
2014/06/09 18:12:50
Done.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Ash.WindowSelector.Items"> |
| <owner>flackr@chromium.org</owner> |
| <owner>kuscher@google.com</owner> |
| <summary> |
| The number of items (single windows or groups of windows such as panels) in |
| - the window selection. Window selection occurs when a user begins alt-tabbing |
| - or presses the overview button (F5 key). |
| + the overview mode. |
|
tdanderson
2014/06/09 17:50:46
Specify that it's recorded as the number of items
Nina
2014/06/09 18:12:50
Done.
|
| </summary> |
| </histogram> |
| +<histogram name="Ash.WindowSelector.KeyPressesOverItemsRatio"> |
| + <owner>flackr@chromium.org</owner> |
| + <owner>tdanderson@chromium.org</owner> |
| + <summary> |
| + The ratio between the arrow key presses and the number of overview items, |
| + expressed as a percentage. |
|
tdanderson
2014/06/09 17:50:46
for a single OM session
Nina
2014/06/09 18:12:50
Done.
|
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Ash.WindowSelector.OverviewClosedItems"> |
| + <owner>flackr@chromium.org</owner> |
| + <owner>tdanderson@chromium.org</owner> |
| + <summary>The number of items closed from the window overview.</summary> |
|
tdanderson
2014/06/09 17:50:46
for a single OM session
Nina
2014/06/09 18:12:51
Done.
|
| +</histogram> |
| + |
| <histogram name="Ash.WindowSelector.TimeBetweenUse" units="milliseconds"> |
| <owner>flackr@chromium.org</owner> |
| <owner>kuscher@google.com</owner> |
| <summary> |
| - The amount of time between uses of window selection to switch between |
| - windows. Window selection is entered by alt-tabbing or by pressing the |
| - overview button (F5 key). |
| + The amount of time between uses of overview mode to switch between windows. |
| </summary> |
| </histogram> |
| @@ -715,11 +737,10 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| <owner>flackr@chromium.org</owner> |
| <owner>kuscher@google.com</owner> |
| <summary> |
| - The amount of time spent in overview mode. Overview mode is engaged when |
| - lingering on a window while alt-tabbing or by pressing the overview button. |
| - The time is measured from the moment the windows begin animating to a |
| - thumbnail size preview to when a window is selected or selection is |
| - canceled. |
| + The amount of time spent in overview mode. Overview mode is engaged by |
| + pressing the overview button. The time is measured from the moment the |
| + windows begin animating to a thumbnail size preview to when a window is |
| + selected or selection is canceled. |
| </summary> |
| </histogram> |
