Fix crash when using surfaceless EGL on Android

Fix crash when using surfaceless EGL on Android

Android's GL context implementation needs to be able to create a
GLNonOwnedContext for Android WebView when sharing the app-managed
surface and context, and a regular EGL context otherwise. Previously it
decided between these based on whether the given GL surface had a surface
handle. This lead to problems when using surfaceless EGL, where
Chromium's surface objects don't have an underlying handle. Use an
explicit flag instead to determine whether a GL surface is owned.

BUG=382349

[Ken Russell (switch to Gerrit), 2014-06-09 18:37:47]

lgtm

[oetuaho-nv, 2014-06-10 07:20:08]

The CQ bit was checked by oetuaho@nvidia.com

[commit-bot: I haz the power, 2014-06-10 07:21:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/320283002/1

[oetuaho-nv, 2014-06-10 08:51:09]

The CQ bit was checked by oetuaho@nvidia.com

[oetuaho-nv, 2014-06-10 08:51:33]

The patch needed a trivial build fix, retrying to commit.

[commit-bot: I haz the power, 2014-06-10 08:53:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/320283002/20001

[oetuaho-nv, 2014-06-10 12:38:38]

Adding Android Webview owners, need approval.

[boliu, 2014-06-10 15:33:01]

PS2 not lgtm

State of things is pretty messy on android webview, and there is no way yet to
test this with only upstream code. Sorry about that.

Every call to this CreateContext function with non-null |service| also needs to
create a GLNonOwnedContext, and this is no longer the case after in PS2:
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/an...

Also this changes the behavior for SurfacelessEGL. I'm not sure what that's used
for. +sievers for this

[no sievers, 2014-06-10 18:30:33]

So we only need this for the context factory to decide what type of context to
create, and it's only needed for Android WebView.
Instead of changing the GLSurface base class API to set a flag saying "you need
to create a GLContext of type X" for this surface, can we let WebView set a
context factory or something?

[no sievers, 2014-06-10 18:46:09]

Btw if it unblocks you feel free to disable surfaceless contexts on Android and
file a bug for us to sort this out wrt WebView.

[commit-bot: I haz the power, 2014-06-10 21:02:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-06-10 21:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 21:12:16]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[oetuaho-nv, 2014-06-11 16:18:20]

On 2014/06/10 18:46:09, sievers wrote:
> Btw if it unblocks you feel free to disable surfaceless contexts on Android
and
> file a bug for us to sort this out wrt WebView.

Right, I uploaded the workaround.

I suppose we can continue using
https://code.google.com/p/chromium/issues/detail?id=382349 for the WebView work,
someone who's in the WebView team can take it over.