net/base/net_util_icu.cc - Issue 320253004: Componentize URLFixerUpper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/net_util_icu.cc

Issue 320253004: Componentize URLFixerUpper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win64 fix Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/net_util_icu.cc

diff --git a/net/base/net_util_icu.cc b/net/base/net_util_icu.cc

index 4c5837566ff37f36341ae94a13d5ae25e34f4a99..4094feeff74a1313e900940ea4d6648c42f0e2a2 100644

--- a/net/base/net_util_icu.cc

+++ b/net/base/net_util_icu.cc

@@ -692,7 +692,7 @@ base::string16 FormatUrlWithAdjustments(

spec.begin() + parsed.CountCharactersBefore(url::Parsed::USERNAME, true));

const char kHTTP[] = "http://";

const char kFTP[] = "ftp.";

- // URLFixerUpper::FixupURL() treats "ftp.foo.com" as ftp://ftp.foo.com. This

+ // url_fixer::FixupURL() treats "ftp.foo.com" as ftp://ftp.foo.com. This

// means that if we trim "http://" off a URL whose host starts with "ftp." and

// the user inputs this into any field subject to fixup (which is basically

// all input fields), the meaning would be changed. (In fact, often the

« no previous file with comments | « components/url_fixer/url_fixer_unittest.cc ('k') | no next file » | no next file with comments »