Chromium Code Reviews| Index: ui/keyboard/keyboard_util.h |
| diff --git a/ui/keyboard/keyboard_util.h b/ui/keyboard/keyboard_util.h |
| index d553c1b4f7272bf6c27499f252921e6666d8a38f..b4e950aa9596ee7b6212d40703777046f99263fb 100644 |
| --- a/ui/keyboard/keyboard_util.h |
| +++ b/ui/keyboard/keyboard_util.h |
| @@ -45,6 +45,13 @@ enum KeyboardOverscrolOverride { |
| KEYBOARD_OVERSCROLL_OVERRIDE_NONE, |
| }; |
| +// An enumeration of keyboard policy settings. |
| +enum KeyboardShowOverride { |
| + KEYBOARD_SHOW_OVERRIDE_DISABLED = 0, |
| + KEYBOARD_SHOW_OVERRIDE_ENABLED = 1, |
|
bartfab (slow)
2014/06/16 10:20:13
Nit 1: Why explicitly set the value of this consta
rsadam
2014/06/16 13:45:35
Done.
|
| + KEYBOARD_SHOW_OVERRIDE_NONE, |
| +}; |
| + |
| // Gets the default keyboard bounds from |window_bounds|. |
| KEYBOARD_EXPORT gfx::Rect DefaultKeyboardBoundsFromWindowBounds( |
| const gfx::Rect& window_bounds); |
| @@ -82,6 +89,9 @@ KEYBOARD_EXPORT bool IsKeyboardOverscrollEnabled(); |
| KEYBOARD_EXPORT void SetKeyboardOverscrollOverride( |
| KeyboardOverscrolOverride override); |
| +// Sets policy override on whether to show the keyboard. |
|
bartfab (slow)
2014/06/16 10:20:13
I see that this is consistent with the rest of the
rsadam
2014/06/16 13:45:35
I'm not sure why one was chosen over the other - t
|
| +KEYBOARD_EXPORT void SetKeyboardShowOverride(KeyboardShowOverride override); |
|
bartfab (slow)
2014/06/16 10:20:13
Nit: Should this be in an #ifdef? It is not used o
rsadam
2014/06/16 13:45:35
The keyboard is only instantiated in chromeos so t
|
| + |
| // Returns true if an IME extension can specify a custom input view for the |
| // virtual keyboard window. |
| KEYBOARD_EXPORT bool IsInputViewEnabled(); |