Add device policy: Kiosk Virtual Keyboard Layout.

ui/keyboard/keyboard_util.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/keyboard/keyboard_util.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
@@ skipping 29 matching lines @@
 
 bool g_accessibility_keyboard_enabled = false;
 
 base::LazyInstance<GURL> g_override_content_url = LAZY_INSTANCE_INITIALIZER;
 
 bool g_touch_keyboard_enabled = false;
 
 keyboard::KeyboardOverscrolOverride g_keyboard_overscroll_override =
     keyboard::KEYBOARD_OVERSCROLL_OVERRIDE_NONE;
 
+keyboard::KeyboardShowOverride g_keyboard_show_override =

[bartfab (slow), 2014/06/16 10:20:13]

Nit: Should this be in an #ifdef? It is not used on any platforms other than
Chrome OS after all.

[rsadam, 2014/06/16 13:45:35]

Tthe virtual keyboard is only ever created on CHROME_OS- I believe this entire
file is already chromeos only.

[bartfab (slow), 2014/06/16 14:14:02]

I see nothing in the gyp files excluding this file from compilation on other ash
platforms.

+    keyboard::KEYBOARD_SHOW_OVERRIDE_NONE;
+
 }  // namespace
 
 namespace keyboard {
 
 gfx::Rect DefaultKeyboardBoundsFromWindowBounds(
     const gfx::Rect& window_bounds) {
   // Initialize default keyboard height to 0. The keyboard window height should
   // only be set by window.resizeTo in virtual keyboard web contents. Otherwise,
   // the default height may conflict with the new height and causing some
   // strange animation issues. For keyboard usability experiments, a full screen
@@ skipping 15 matching lines @@
 }
 
 void SetAccessibilityKeyboardEnabled(bool enabled) {
   g_accessibility_keyboard_enabled = enabled;
 }
 
 bool GetAccessibilityKeyboardEnabled() {
   return g_accessibility_keyboard_enabled;
 }
 
 void SetTouchKeyboardEnabled(bool enabled) {

[bartfab (slow), 2014/06/16 10:20:13]

What UI is used to control this? Can we gray out this UI if a policy override is
in effect?

[rsadam, 2014/06/16 13:45:34]

There isn't a UI for this - it's enabled when the user enters  TouchView mode,
which is triggered on certain combinations of screen rotations.

   g_touch_keyboard_enabled = enabled;
 }
 
 bool GetTouchKeyboardEnabled() {
   return g_touch_keyboard_enabled;
 }
 
 std::string GetKeyboardLayout() {
   // TODO(bshe): layout string is currently hard coded. We should use more
   // standard keyboard layouts.
   return GetAccessibilityKeyboardEnabled() ? "system-qwerty" : "qwerty";
 }
 
 bool IsKeyboardEnabled() {
-  return g_accessibility_keyboard_enabled ||
-      CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kEnableVirtualKeyboard) ||
-      IsKeyboardUsabilityExperimentEnabled() ||
-      g_touch_keyboard_enabled;
+  // Accessibility setting prioritized over policy setting.
+  if (g_accessibility_keyboard_enabled)

[bartfab (slow), 2014/06/16 10:20:13]

Could you check whether this can be used to override the policy:

* Admin sets policy to "force-enable VK"
* VK shows
* User enables accessibility keyboard, which takes precedence
* A11y VK shows
* I presume the regular VK hides automatically?
* User disables accessibility keyboard
* A11y VK hides

Will the regular VK automatically re-show at that point?

[rsadam, 2014/06/16 13:45:34]

The keyboard only shows on text input focus - but yes it does reappear.

+    return true;
+  // Policy strictly disables showing a virtual keyboard.
+  if (g_keyboard_show_override == keyboard::KEYBOARD_SHOW_OVERRIDE_DISABLED)
+    return false;
+  // Check if any of the flags are enabled.
+  return CommandLine::ForCurrentProcess()->HasSwitch(
+             switches::kEnableVirtualKeyboard) ||
+         IsKeyboardUsabilityExperimentEnabled() || g_touch_keyboard_enabled ||

[bartfab (slow), 2014/06/16 10:20:13]

Nit: Could you reformat this so there is one condition per line? It would be
easier to read if g_touch_keyboard_enabled was on its own line.

[rsadam, 2014/06/16 13:45:34]

Done.

+         (g_keyboard_show_override == keyboard::KEYBOARD_SHOW_OVERRIDE_ENABLED);
 }
 
 bool IsKeyboardUsabilityExperimentEnabled() {
   return CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kKeyboardUsabilityExperiment);
 }
 
 bool IsKeyboardOverscrollEnabled() {
   if (!IsKeyboardEnabled())
     return false;
@@ skipping 14 matching lines @@
       switches::kDisableVirtualKeyboardOverscroll)) {
     return false;
   }
   return true;
 }
 
 void SetKeyboardOverscrollOverride(KeyboardOverscrolOverride override) {
   g_keyboard_overscroll_override = override;
 }
 
+void SetKeyboardShowOverride(KeyboardShowOverride override) {
+  g_keyboard_show_override = override;
+}
+
 bool IsInputViewEnabled() {
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableInputView))
     return true;
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableInputView))
     return false;
   // Default value if no command line flags specified.
   return true;
 }
 
 bool IsExperimentalInputViewEnabled() {
@@ skipping 212 matching lines @@
 }
 
 void LogKeyboardControlEvent(KeyboardControlEvent event) {
   UMA_HISTOGRAM_ENUMERATION(
       "VirtualKeyboard.KeyboardControlEvent",
       event,
       keyboard::KEYBOARD_CONTROL_MAX);
 }
 
 }  // namespace keyboard