Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 320193002: Consolidates view_manager typedefs (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Consolidates view_manager typedefs Down to just 2! BUG=365012 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275835

Patch Set 1 #

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -353 lines) Patch
M mojo/examples/window_manager/window_manager.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_private.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_private.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h View 3 chunks +31 lines, -34 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 26 chunks +58 lines, -66 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_private.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_tree_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_tree_node_private.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 9 chunks +22 lines, -23 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_tree_node_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager_types.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_tree_node.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/view_manager/ids.h View 1 3 chunks +11 lines, -13 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 7 chunks +19 lines, -19 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 3 chunks +23 lines, -29 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 7 chunks +16 lines, -21 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 8 chunks +27 lines, -27 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 18 chunks +28 lines, -30 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 15 chunks +36 lines, -45 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
6 years, 6 months ago (2014-06-07 23:43:30 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 6 months ago (2014-06-09 17:37:29 UTC) #2
sky
6 years, 6 months ago (2014-06-09 17:45:03 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r275835 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698