Fix token URL policy processing. Refactor/clean-up individual policy processing. Separate policy ap…

Fix token URL policy processing.
Refactor/clean-up individual policy processing.
Separate policy application for config-dependent policies, and re-apply them when the config changes.

BUG=381762
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276325

[rmsousa, 2014-06-06 23:23:14]

Updating the token policies correctly with the "old pass-by-value, check if
value is the same" pattern would end up very ugly and redundant: I would have to
try to load all three (defaulting to the old value), then pass all three into
the function, that would again test them for equality before applying the
policy.

Looking at the code, it turns out most of that pattern is redundant/unnecessary
- after the first load, policy_watcher only sets policies that changed, so most
of the equality tests were unnecessary - we can just try to load the appropriate
policy, apply if it succeeds, ignore if it fails.

So I took the chance to refactor/simplify/uniformize all the policy updaters to
just take the policy dictionary, and apply the policy directly if there's
something there.

While refactoring this, I also took the chance to fix a longstanding TODO -
apply the relevant policies when the config changes (the config change in
question can never happen during the regular flow, the user would have to
manually edit the config file to trigger that scenario)

https://codereview.chromium.org/320123002/diff/20001/remoting/host/remoting_m...
File remoting/host/remoting_me2me_host.cc (right):

https://codereview.chromium.org/320123002/diff/20001/remoting/host/remoting_m...
remoting/host/remoting_me2me_host.cc:290: 
empty line separates config variables from policy variables.

[Sergey Ulanov, 2014-06-07 00:51:45]

lgtm

https://codereview.chromium.org/320123002/diff/20001/remoting/host/remoting_m...
File remoting/host/remoting_me2me_host.cc (right):

https://codereview.chromium.org/320123002/diff/20001/remoting/host/remoting_m...
remoting/host/remoting_me2me_host.cc:930: HOST_LOG << "Policy enables NAT
traversal.";
add {} please

https://codereview.chromium.org/320123002/diff/20001/remoting/host/remoting_m...
remoting/host/remoting_me2me_host.cc:1089: HOST_LOG << "Policy enables client
pairing.";
add {} please

[rmsousa, 2014-06-07 01:08:52]

The CQ bit was checked by rmsousa@chromium.org

[rmsousa, 2014-06-07 01:09:03]

https://codereview.chromium.org/320123002/diff/20001/remoting/host/remoting_m...
File remoting/host/remoting_me2me_host.cc (right):

https://codereview.chromium.org/320123002/diff/20001/remoting/host/remoting_m...
remoting/host/remoting_me2me_host.cc:930: HOST_LOG << "Policy enables NAT
traversal.";
On 2014/06/07 00:51:44, Sergey Ulanov wrote:
> add {} please

Done.

https://codereview.chromium.org/320123002/diff/20001/remoting/host/remoting_m...
remoting/host/remoting_me2me_host.cc:1089: HOST_LOG << "Policy enables client
pairing.";
On 2014/06/07 00:51:45, Sergey Ulanov wrote:
> add {} please

Done.

[commit-bot: I haz the power, 2014-06-07 01:10:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rmsousa@chromium.org/320123002/40001

[commit-bot: I haz the power, 2014-06-07 10:10:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-07 11:48:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-07 11:48:19]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[Wez, 2014-06-08 00:18:44]

Thanks for cleaning this up!

[rmsousa, 2014-06-10 23:29:24]

The CQ bit was checked by rmsousa@chromium.org

[commit-bot: I haz the power, 2014-06-10 23:33:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rmsousa@chromium.org/320123002/50001

[commit-bot: I haz the power, 2014-06-11 09:52:12]

Change committed as 276325