Fix a bug wherein we'd release a scoped_ptr and dereference it in the same line of code. That work…

Fix a bug wherein we'd release a scoped_ptr and dereference it in the same line of code.  That worked by luck on some compilers, but failed on OSX, in a way only revealed by tryjobs on a subsequent blink change.

BUG=108012
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275623

[ericu, 2014-06-06 22:43:02]

This is the fix for the mac-only failure of the blink CL.

[jsbell, 2014-06-06 23:02:06]

lgtm...


But why are we even posting the params object and a pointer to one of its
members separately?

ISTM we could drop the blob_or_file_infos argument from
BlobLookupForCursorPrefetch and dig it out from params within the function.

But I may be missing some subtlety.

https://codereview.chromium.org/320103003/diff/1/content/browser/indexed_db/i...
File content/browser/indexed_db/indexed_db_callbacks.cc (right):

https://codereview.chromium.org/320103003/diff/1/content/browser/indexed_db/i...
content/browser/indexed_db/indexed_db_callbacks.cc:457:
base::Unretained(values_blob_infos)));
I suppose it's shorter to change the above reference into a pointer, rather than
adding another

std::vector<std::vector<IndexedDBMsg_BlobOrFileInfo> >* infos =
&params->blob_or_file_infos;

... right above this call?

[ericu, 2014-06-07 00:11:31]

On 2014/06/06 23:02:06, jsbell wrote:
> lgtm...
> 
> 
> But why are we even posting the params object and a pointer to one of its
> members separately?
> 
> ISTM we could drop the blob_or_file_infos argument from
> BlobLookupForCursorPrefetch and dig it out from params within the function.
> 
> But I may be missing some subtlety.

Nope; I'd carried that over from the templated version of the function, where we
couldn't know the type of the param in the called function, so we had to pass
the blob info separately.  I've just removed the parameter, and it's much nicer
now.

[ericu, 2014-06-07 00:12:47]

The CQ bit was checked by ericu@chromium.org

[commit-bot: I haz the power, 2014-06-07 00:16:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ericu@chromium.org/320103003/20001

[commit-bot: I haz the power, 2014-06-07 05:15:39]

Change committed as 275623