Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-item-auto-placement-automatic-span.html

Issue 320093002: [CSS Grid Layout] Named grid line span not allowed for automatic positions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@span-named-grid-line-to-upload
Patch Set: Patch for landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/rendering/RenderGrid.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <link href="resources/grid.css" rel="stylesheet"> 3 <link href="resources/grid.css" rel="stylesheet">
4 <style> 4 <style>
5 .grid { 5 .grid {
6 grid-auto-rows: 50px; 6 grid-auto-rows: 50px;
7 grid-auto-columns: 100px; 7 grid-auto-columns: 100px;
8 } 8 }
9 9
10 .gridNamedGridLinesColumns { 10 .gridNamedGridLinesColumns {
(...skipping 29 matching lines...) Expand all
40 } 40 }
41 41
42 .autoRowSpanning2AutoColumnSpanning2 { 42 .autoRowSpanning2AutoColumnSpanning2 {
43 background-color: olive; 43 background-color: olive;
44 grid-column: span 2; 44 grid-column: span 2;
45 grid-row: span 2; 45 grid-row: span 2;
46 } 46 }
47 47
48 .autoRowAutoColumnSpanningLine { 48 .autoRowAutoColumnSpanningLine {
49 background-color: indigo; 49 background-color: indigo;
50 grid-column: span line; 50 grid-column: span line; /* This is treated as "span 1". */
51 grid-row: auto; 51 grid-row: auto;
52 } 52 }
53 53
54 .autoRowSpanningLineAutoColumn { 54 .autoRowSpanningLineAutoColumn {
55 background-color: moccasin; 55 background-color: moccasin;
56 grid-column: auto; 56 grid-column: auto;
57 grid-row: span line; 57 grid-row: span line; /* This is treated as "span 1". */
58 } 58 }
59 59
60 .autoRowAutoColumnSpanning2Line { 60 .autoRowAutoColumnSpanning2Line {
61 background-color: sienna; 61 background-color: sienna;
62 grid-column: span 2 line; 62 grid-column: span 2 line; /* This is treated as "span 1". */
63 grid-row: auto; 63 grid-row: auto;
64 } 64 }
65 65
66 .autoRowSpanning2LineAutoColumn { 66 .autoRowSpanning2LineAutoColumn {
67 background-color: tomato; 67 background-color: tomato;
68 grid-column: auto; 68 grid-column: auto;
69 grid-row: span 2 line; 69 grid-row: span 2 line; /* This is treated as "span 1". */
70 } 70 }
71 </style> 71 </style>
72 <script src="../../resources/check-layout.js"></script> 72 <script src="../../resources/check-layout.js"></script>
73 <body onload="checkLayout('.grid');"> 73 <body onload="checkLayout('.grid');">
74 74
75 <p>Thist test checks that span is supported in auto-placement for automatic posi tions.</p> 75 <p>Thist test checks that span is supported in auto-placement for automatic posi tions.</p>
76 76
77 <div style="position: relative"> 77 <div style="position: relative">
78 <div class="grid gridAutoFlowRow"> 78 <div class="grid gridAutoFlowRow">
79 <div class="sizedToGridArea autoRowAutoColumnSpanning2" data-offset-x="0 " data-offset-y="0" data-expected-width="200" data-expected-height="50"></div> 79 <div class="sizedToGridArea autoRowAutoColumnSpanning2" data-offset-x="0 " data-offset-y="0" data-expected-width="200" data-expected-height="50"></div>
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 <div class="sizedToGridArea autoRowThirdColumn" data-offset-x="200" data -offset-y="0" data-expected-width="100" data-expected-height="50"></div> 114 <div class="sizedToGridArea autoRowThirdColumn" data-offset-x="200" data -offset-y="0" data-expected-width="100" data-expected-height="50"></div>
115 <div class="sizedToGridArea autoRowSpanning2AutoColumnSpanning2" data-of fset-x="100" data-offset-y="50" data-expected-width="200" data-expected-height=" 100"></div> 115 <div class="sizedToGridArea autoRowSpanning2AutoColumnSpanning2" data-of fset-x="100" data-offset-y="50" data-expected-width="200" data-expected-height=" 100"></div>
116 <div class="sizedToGridArea autoRowSpanning3AutoColumn" data-offset-x="0 " data-offset-y="100" data-expected-width="100" data-expected-height="150"></div > 116 <div class="sizedToGridArea autoRowSpanning3AutoColumn" data-offset-x="0 " data-offset-y="100" data-expected-width="100" data-expected-height="150"></div >
117 <div class="sizedToGridArea autoRowSpanning2AutoColumnSpanning2" data-of fset-x="100" data-offset-y="150" data-expected-width="200" data-expected-height= "100"></div> 117 <div class="sizedToGridArea autoRowSpanning2AutoColumnSpanning2" data-of fset-x="100" data-offset-y="150" data-expected-width="200" data-expected-height= "100"></div>
118 </div> 118 </div>
119 </div> 119 </div>
120 120
121 <div style="position: relative"> 121 <div style="position: relative">
122 <div class="grid gridAutoFlowRow gridNamedGridLinesColumns"> 122 <div class="grid gridAutoFlowRow gridNamedGridLinesColumns">
123 <div class="sizedToGridArea autoRowFirstColumn" data-offset-x="0" data-o ffset-y="0" data-expected-width="50" data-expected-height="50"></div> 123 <div class="sizedToGridArea autoRowFirstColumn" data-offset-x="0" data-o ffset-y="0" data-expected-width="50" data-expected-height="50"></div>
124 <div class="sizedToGridArea autoRowAutoColumnSpanning2Line" data-offset- x="50" data-offset-y="0" data-expected-width="300" data-expected-height="50"></d iv> 124 <div class="sizedToGridArea autoRowAutoColumnSpanning2Line" data-offset- x="50" data-offset-y="0" data-expected-width="100" data-expected-height="50"></d iv>
125 <div class="sizedToGridArea autoRowSecondColumn" data-offset-x="50" data -offset-y="50" data-expected-width="100" data-expected-height="50"></div> 125 <div class="sizedToGridArea autoRowSecondColumn" data-offset-x="50" data -offset-y="50" data-expected-width="100" data-expected-height="50"></div>
126 <div class="sizedToGridArea autoRowAutoColumnSpanning2Line" data-offset- x="150" data-offset-y="50" data-expected-width="200" data-expected-height="50">< /div> 126 <div class="sizedToGridArea autoRowAutoColumnSpanning2Line" data-offset- x="150" data-offset-y="0" data-expected-width="200" data-expected-height="50"></ div>
127 <div class="sizedToGridArea autoRowThirdColumn" data-offset-x="150" data -offset-y="50" data-expected-width="200" data-expected-height="50"></div>
128 <div class="sizedToGridArea autoRowAutoColumnSpanningLine" data-offset-x ="0" data-offset-y="50" data-expected-width="50" data-expected-height="50"></div >
129 <div class="sizedToGridArea autoRowAutoColumnSpanning2Line" data-offset- x="0" data-offset-y="100" data-expected-width="50" data-expected-height="50"></d iv>
130 <div class="sizedToGridArea autoRowFirstColumn" data-offset-x="0" data-o ffset-y="150" data-expected-width="50" data-expected-height="50"></div>
131 <div class="sizedToGridArea autoRowAutoColumnSpanningLine" data-offset-x ="50" data-offset-y="100" data-expected-width="100" data-expected-height="50"></ div>
127 <div class="sizedToGridArea autoRowThirdColumn" data-offset-x="150" data -offset-y="100" data-expected-width="200" data-expected-height="50"></div> 132 <div class="sizedToGridArea autoRowThirdColumn" data-offset-x="150" data -offset-y="100" data-expected-width="200" data-expected-height="50"></div>
128 <div class="sizedToGridArea autoRowAutoColumnSpanningLine" data-offset-x ="0" data-offset-y="100" data-expected-width="150" data-expected-height="50"></d iv> 133 <div class="sizedToGridArea autoRowAutoColumnSpanningLine" data-offset-x ="50" data-offset-y="150" data-expected-width="100" data-expected-height="50"></ div>
129 <div class="sizedToGridArea autoRowAutoColumnSpanning2Line" data-offset- x="0" data-offset-y="150" data-expected-width="350" data-expected-height="50"></ div> 134 <div class="sizedToGridArea autoRowAutoColumnSpanningLine" data-offset-x ="150" data-offset-y="150" data-expected-width="200" data-expected-height="50">< /div>
130 <div class="sizedToGridArea autoRowFirstColumn" data-offset-x="0" data-o ffset-y="50" data-expected-width="50" data-expected-height="50"></div>
131 <div class="sizedToGridArea autoRowFirstColumn" data-offset-x="0" data-o ffset-y="200" data-expected-width="50" data-expected-height="50"></div>
132 <div class="sizedToGridArea autoRowAutoColumnSpanningLine" data-offset-x ="50" data-offset-y="200" data-expected-width="100" data-expected-height="50"></ div>
133 <div class="sizedToGridArea autoRowThirdColumn" data-offset-x="150" data -offset-y="200" data-expected-width="200" data-expected-height="50"></div>
134 <div class="sizedToGridArea autoRowAutoColumnSpanningLine" data-offset-x ="0" data-offset-y="250" data-expected-width="150" data-expected-height="50"></d iv>
135 <div class="sizedToGridArea autoRowAutoColumnSpanningLine" data-offset-x ="150" data-offset-y="250" data-expected-width="200" data-expected-height="50">< /div>
136 </div> 135 </div>
137 </div> 136 </div>
138 137
139 <div style="position: relative"> 138 <div style="position: relative">
140 <div class="grid gridAutoFlowColumn"> 139 <div class="grid gridAutoFlowColumn">
141 <div class="sizedToGridArea autoRowSpanning2AutoColumn" data-offset-x="0 " data-offset-y="0" data-expected-width="100" data-expected-height="100"></div> 140 <div class="sizedToGridArea autoRowSpanning2AutoColumn" data-offset-x="0 " data-offset-y="0" data-expected-width="100" data-expected-height="100"></div>
142 <div class="sizedToGridArea autoRowAutoColumn" data-offset-x="0" data-of fset-y="100" data-expected-width="100" data-expected-height="50"></div> 141 <div class="sizedToGridArea autoRowAutoColumn" data-offset-x="0" data-of fset-y="100" data-expected-width="100" data-expected-height="50"></div>
143 <div class="sizedToGridArea autoRowAutoColumn" data-offset-x="100" data- offset-y="0" data-expected-width="100" data-expected-height="50"></div> 142 <div class="sizedToGridArea autoRowAutoColumn" data-offset-x="100" data- offset-y="0" data-expected-width="100" data-expected-height="50"></div>
144 <div class="sizedToGridArea autoRowSpanning2AutoColumn" data-offset-x="1 00" data-offset-y="50" data-expected-width="100" data-expected-height="100"></di v> 143 <div class="sizedToGridArea autoRowSpanning2AutoColumn" data-offset-x="1 00" data-offset-y="50" data-expected-width="100" data-expected-height="100"></di v>
145 <div class="sizedToGridArea autoRowSpanning3AutoColumn" data-offset-x="2 00" data-offset-y="0" data-expected-width="100" data-expected-height="150"></div > 144 <div class="sizedToGridArea autoRowSpanning3AutoColumn" data-offset-x="2 00" data-offset-y="0" data-expected-width="100" data-expected-height="150"></div >
(...skipping 30 matching lines...) Expand all
176 <div class="sizedToGridArea thirdRowAutoColumn" data-offset-x="0" data-o ffset-y="100" data-expected-width="100" data-expected-height="50"></div> 175 <div class="sizedToGridArea thirdRowAutoColumn" data-offset-x="0" data-o ffset-y="100" data-expected-width="100" data-expected-height="50"></div>
177 <div class="sizedToGridArea autoRowSpanning2AutoColumnSpanning2" data-of fset-x="100" data-offset-y="50" data-expected-width="200" data-expected-height=" 100"></div> 176 <div class="sizedToGridArea autoRowSpanning2AutoColumnSpanning2" data-of fset-x="100" data-offset-y="50" data-expected-width="200" data-expected-height=" 100"></div>
178 <div class="sizedToGridArea autoRowAutoColumnSpanning3" data-offset-x="2 00" data-offset-y="0" data-expected-width="300" data-expected-height="50"></div> 177 <div class="sizedToGridArea autoRowAutoColumnSpanning3" data-offset-x="2 00" data-offset-y="0" data-expected-width="300" data-expected-height="50"></div>
179 <div class="sizedToGridArea autoRowSpanning2AutoColumnSpanning2" data-of fset-x="300" data-offset-y="50" data-expected-width="200" data-expected-height=" 100"></div> 178 <div class="sizedToGridArea autoRowSpanning2AutoColumnSpanning2" data-of fset-x="300" data-offset-y="50" data-expected-width="200" data-expected-height=" 100"></div>
180 </div> 179 </div>
181 </div> 180 </div>
182 181
183 <div style="position: relative"> 182 <div style="position: relative">
184 <div class="grid gridAutoFlowColumn gridNamedGridLinesRows"> 183 <div class="grid gridAutoFlowColumn gridNamedGridLinesRows">
185 <div class="sizedToGridArea firstRowAutoColumn" data-offset-x="0" data-o ffset-y="0" data-expected-width="100" data-expected-height="50"></div> 184 <div class="sizedToGridArea firstRowAutoColumn" data-offset-x="0" data-o ffset-y="0" data-expected-width="100" data-expected-height="50"></div>
186 <div class="sizedToGridArea autoRowSpanning2LineAutoColumn" data-offset- x="0" data-offset-y="50" data-expected-width="100" data-expected-height="300"></ div> 185 <div class="sizedToGridArea autoRowSpanning2LineAutoColumn" data-offset- x="0" data-offset-y="50" data-expected-width="100" data-expected-height="100"></ div>
187 <div class="sizedToGridArea secondRowAutoColumn" data-offset-x="100" dat a-offset-y="50" data-expected-width="100" data-expected-height="100"></div> 186 <div class="sizedToGridArea secondRowAutoColumn" data-offset-x="100" dat a-offset-y="50" data-expected-width="100" data-expected-height="100"></div>
188 <div class="sizedToGridArea autoRowSpanning2LineAutoColumn" data-offset- x="100" data-offset-y="150" data-expected-width="100" data-expected-height="200" ></div> 187 <div class="sizedToGridArea autoRowSpanning2LineAutoColumn" data-offset- x="0" data-offset-y="150" data-expected-width="100" data-expected-height="200">< /div>
188 <div class="sizedToGridArea thirdRowAutoColumn" data-offset-x="100" data -offset-y="150" data-expected-width="100" data-expected-height="200"></div>
189 <div class="sizedToGridArea autoRowSpanningLineAutoColumn" data-offset-x ="100" data-offset-y="0" data-expected-width="100" data-expected-height="50"></d iv>
190 <div class="sizedToGridArea autoRowSpanning2LineAutoColumn" data-offset- x="200" data-offset-y="0" data-expected-width="100" data-expected-height="50"></ div>
191 <div class="sizedToGridArea firstRowAutoColumn" data-offset-x="300" data -offset-y="0" data-expected-width="100" data-expected-height="50"></div>
192 <div class="sizedToGridArea autoRowSpanningLineAutoColumn" data-offset-x ="200" data-offset-y="50" data-expected-width="100" data-expected-height="100">< /div>
189 <div class="sizedToGridArea thirdRowAutoColumn" data-offset-x="200" data -offset-y="150" data-expected-width="100" data-expected-height="200"></div> 193 <div class="sizedToGridArea thirdRowAutoColumn" data-offset-x="200" data -offset-y="150" data-expected-width="100" data-expected-height="200"></div>
190 <div class="sizedToGridArea autoRowSpanningLineAutoColumn" data-offset-x ="200" data-offset-y="0" data-expected-width="100" data-expected-height="150"></ div> 194 <div class="sizedToGridArea autoRowSpanningLineAutoColumn" data-offset-x ="300" data-offset-y="50" data-expected-width="100" data-expected-height="100">< /div>
191 <div class="sizedToGridArea autoRowSpanning2LineAutoColumn" data-offset- x="300" data-offset-y="0" data-expected-width="100" data-expected-height="350">< /div> 195 <div class="sizedToGridArea autoRowSpanningLineAutoColumn" data-offset-x ="300" data-offset-y="150" data-expected-width="100" data-expected-height="200"> </div-->
192 <div class="sizedToGridArea firstRowAutoColumn" data-offset-x="100" data -offset-y="0" data-expected-width="100" data-expected-height="50"></div>
193 <div class="sizedToGridArea firstRowAutoColumn" data-offset-x="400" data -offset-y="0" data-expected-width="100" data-expected-height="50"></div>
194 <div class="sizedToGridArea autoRowSpanningLineAutoColumn" data-offset-x ="400" data-offset-y="50" data-expected-width="100" data-expected-height="100">< /div>
195 <div class="sizedToGridArea thirdRowAutoColumn" data-offset-x="400" data -offset-y="150" data-expected-width="100" data-expected-height="200"></div>
196 <div class="sizedToGridArea autoRowSpanningLineAutoColumn" data-offset-x ="500" data-offset-y="0" data-expected-width="100" data-expected-height="150"></ div>
197 <div class="sizedToGridArea autoRowSpanningLineAutoColumn" data-offset-x ="500" data-offset-y="150" data-expected-width="100" data-expected-height="200"> </div>
198 </div> 196 </div>
199 </div> 197 </div>
200 198
201 </body> 199 </body>
202 </html> 200 </html>
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/RenderGrid.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698