Issue 320063003: use __atomics in SkBarriers_tsan.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 320063003: use __atomics in SkBarriers_tsan.h (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
bungeman-skia, mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

use __atomics in SkBarriers_tsan.h I am having a hard time getting TSAN's own atomic hooks to work on our bots, but __atomic_foo work fine and are understood just fine by TSAN. BUG=skia: Committed: https://skia.googlesource.com/skia/+/19cae4fa2cf667acb05d2e5a1bf0a5dab606fe68

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -31 lines)			Patch
	M	src/ports/SkBarriers_tsan.h	View		1 chunk	+8 lines, -31 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/320063003/1

6 years, 6 months ago (2014-06-06 21:43:51 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-06 22:11:09 UTC) #5

Message was sent while issue was closed.

Change committed as 19cae4fa2cf667acb05d2e5a1bf0a5dab606fe68