Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 320063002: NetworkingPrivate API events should supply list of GUIDs, not service paths (Closed)

Created:
6 years, 6 months ago by tbarzic
Modified:
6 years, 6 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, mef
Visibility:
Public.

Description

NetworkingPrivate API events should supply list of GUIDs, not service paths Update API tests so they don't assume service_path == GUID BUG=381786 TBR=mef (updated test expectations in components/wifi/fake_wifi_service.cc) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276420

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -68 lines) Patch
M chrome/browser/chromeos/customization_document_unittest.cc View 1 2 3 4 5 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/managed/managed_user_test_base.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen_browsertest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 2 3 4 5 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_test_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_test_impl.cc View 1 2 3 4 5 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc View 1 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/networking/test.js View 21 chunks +40 lines, -38 lines 0 comments Download
M components/wifi/fake_wifi_service.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
tbarzic
6 years, 6 months ago (2014-06-06 20:58:49 UTC) #1
stevenjb
https://codereview.chromium.org/320063002/diff/40001/chrome/browser/chromeos/customization_document_unittest.cc File chrome/browser/chromeos/customization_document_unittest.cc (right): https://codereview.chromium.org/320063002/diff/40001/chrome/browser/chromeos/customization_document_unittest.cc#newcode239 chrome/browser/chromeos/customization_document_unittest.cc:239: kStubEthernetServicePath); /* guid */ (here and elsewhere) https://codereview.chromium.org/320063002/diff/40001/chrome/browser/chromeos/login/wizard_controller_browsertest.cc File ...
6 years, 6 months ago (2014-06-06 21:43:50 UTC) #2
tbarzic
https://codereview.chromium.org/320063002/diff/40001/chrome/browser/chromeos/customization_document_unittest.cc File chrome/browser/chromeos/customization_document_unittest.cc (right): https://codereview.chromium.org/320063002/diff/40001/chrome/browser/chromeos/customization_document_unittest.cc#newcode239 chrome/browser/chromeos/customization_document_unittest.cc:239: kStubEthernetServicePath); On 2014/06/06 21:43:49, stevenjb wrote: > /* guid ...
6 years, 6 months ago (2014-06-06 22:00:41 UTC) #3
stevenjb
lgtm
6 years, 6 months ago (2014-06-06 22:05:22 UTC) #4
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 6 months ago (2014-06-07 15:48:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/320063002/80001
6 years, 6 months ago (2014-06-07 15:49:56 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 16:10:04 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-07 16:11:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_dbg/builds/30254)
6 years, 6 months ago (2014-06-07 16:11:49 UTC) #9
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 6 months ago (2014-06-09 21:20:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/320063002/100001
6 years, 6 months ago (2014-06-09 21:21:31 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 09:31:27 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 12:28:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150235)
6 years, 6 months ago (2014-06-10 12:28:55 UTC) #14
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 6 months ago (2014-06-10 16:14:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/320063002/100001
6 years, 6 months ago (2014-06-10 16:19:43 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 17:00:22 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 17:39:23 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150458)
6 years, 6 months ago (2014-06-10 17:39:24 UTC) #19
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 6 months ago (2014-06-11 15:53:22 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/320063002/100001
6 years, 6 months ago (2014-06-11 15:54:55 UTC) #21
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 16:11:57 UTC) #22
Message was sent while issue was closed. 
Change committed as 276420

Powered by Google App Engine
This is Rietveld 408576698