Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 320043002: Revert of Remove now obsolete checkdeps copy (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Remove now obsolete checkdeps copy (https://codereview.chromium.org/307333003/) Reason for revert: Still referenced from blink Original issue's description: > Remove now obsolete checkdeps copy > > BUG=none > R=brettw@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275419 TBR=brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1951 lines, -0 lines) Patch
A tools/checkdeps/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/checkdeps/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A tools/checkdeps/PRESUBMIT.py View 1 chunk +25 lines, -0 lines 0 comments Download
A tools/checkdeps/builddeps.py View 1 chunk +375 lines, -0 lines 0 comments Download
A tools/checkdeps/checkdeps.py View 1 chunk +237 lines, -0 lines 0 comments Download
A tools/checkdeps/checkdeps_test.py View 1 chunk +177 lines, -0 lines 0 comments Download
A tools/checkdeps/cpp_checker.py View 1 chunk +113 lines, -0 lines 0 comments Download
A tools/checkdeps/graphdeps.py View 1 chunk +407 lines, -0 lines 0 comments Download
A tools/checkdeps/java_checker.py View 1 chunk +107 lines, -0 lines 0 comments Download
A tools/checkdeps/results.py View 1 chunk +178 lines, -0 lines 0 comments Download
A tools/checkdeps/rules.py View 1 chunk +178 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/allowed/DEPS View 1 chunk +12 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/allowed/foo_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/allowed/not_a_test.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/allowed/test.h View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/checkdeps_test/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/checkdeps_test/allowed/DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/checkdeps_test/allowed/foo_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/checkdeps_test/allowed/not_a_test.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/checkdeps_test/allowed/test.h View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/checkdeps_test/disallowed/allowed/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/checkdeps_test/disallowed/allowed/skipped/test.h View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/checkdeps_test/disallowed/allowed/test.h View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/checkdeps_test/disallowed/test.h View 1 chunk +12 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/disallowed/allowed/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/disallowed/allowed/skipped/test.h View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/disallowed/allowed/test.h View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/disallowed/foo_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A tools/checkdeps/testdata/disallowed/test.h View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Remove now obsolete checkdeps copy
6 years, 6 months ago (2014-06-06 18:24:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/320043002/1
6 years, 6 months ago (2014-06-06 18:26:09 UTC) #2
commit-bot: I haz the power
Change committed as 275482
6 years, 6 months ago (2014-06-06 18:27:41 UTC) #3
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-12 17:29:33 UTC) #4
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/334743002/ by jochen@chromium.org.

The reason for reverting is: should be safe to land now.

Powered by Google App Engine
This is Rietveld 408576698